From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC v4 3/6] nl80211: Implement TX of control port frames
Date: Mon, 19 Feb 2018 13:44:57 +0100 [thread overview]
Message-ID: <1519044297.16723.4.camel@sipsolutions.net> (raw)
In-Reply-To: <20180201010420.6102-4-denkenz@gmail.com> (sfid-20180201_020437_479619_BE4C79BC)
On Wed, 2018-01-31 at 19:04 -0600, Denis Kenzior wrote:
>
> + switch (wdev->iftype) {
> + case NL80211_IFTYPE_STATION:
> + if (wdev->current_bss)
> + break;
> + err = -ENOTCONN;
> + goto out;
> + default:
> + err = -EOPNOTSUPP;
> + goto out;
> + }
>
Why restrict this to client mode? At the very least, P2P_CLIENT really
should be listed there, but I'm not sure why not also support it in
IBSS, and AP/P2P_GO/AP_VLAN modes?
We could do this in a separate patch, but then we have to define
different flags for the modes which seems somewhat pointless.
johannes
next prev parent reply other threads:[~2018-02-19 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 1:04 [RFC v4 0/6] EAPoL over NL80211 Denis Kenzior
2018-02-01 1:04 ` [RFC v4 1/6] uapi: Add 802.11 Preauthentication to if_ether Denis Kenzior
2018-02-19 12:41 ` Johannes Berg
2018-02-01 1:04 ` [RFC v4 2/6] nl80211: Add CMD_CONTROL_PORT_FRAME API Denis Kenzior
2018-02-01 1:04 ` [RFC v4 3/6] nl80211: Implement TX of control port frames Denis Kenzior
2018-02-19 12:44 ` Johannes Berg [this message]
2018-02-20 16:52 ` Denis Kenzior
2018-02-01 1:04 ` [RFC v4 4/6] nl80211: Add CONTROL_PORT_OVER_NL80211 attribute Denis Kenzior
2018-02-01 1:04 ` [RFC v4 5/6] mac80211: Add support for tx_control_port Denis Kenzior
2018-02-01 1:04 ` [RFC v4 6/6] mac80211: Send control port frames over nl80211 Denis Kenzior
2018-02-19 12:49 ` [RFC v4 0/6] EAPoL over NL80211 Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519044297.16723.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).