linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>, nbd@nbd.name
Cc: linux-wireless@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH] mt76: enable MAC80211_LEDS by default
Date: Tue, 20 Mar 2018 23:45:16 +0100	[thread overview]
Message-ID: <1521585916.19123.3.camel@sipsolutions.net> (raw)
In-Reply-To: <a159566d0970fb5c43da7758d8281b594b6ca48e.1521209538.git.lorenzo.bianconi@redhat.com> (sfid-20180316_154622_034123_84A96CF1)

On Fri, 2018-03-16 at 15:45 +0100, Lorenzo Bianconi wrote:
> --- a/drivers/net/wireless/mediatek/mt76/Kconfig
> +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
> @@ -1,5 +1,8 @@
>  config MT76_CORE
>  	tristate
> +	select MAC80211_LEDS

Should drivers really mess with mac80211's configuration that way? I
believe this is a user-visible config, no?

johannes

  reply	other threads:[~2018-03-20 22:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1521209538.git.lorenzo.bianconi@redhat.com>
2018-03-16 14:45 ` [PATCH] mt76: enable MAC80211_LEDS by default Lorenzo Bianconi
2018-03-20 22:45   ` Johannes Berg [this message]
2018-03-21  6:59     ` Arnd Bergmann
2018-03-21 15:27       ` Lorenzo Bianconi
2018-03-22  1:59         ` Arnd Bergmann
2018-03-22 10:22           ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521585916.19123.3.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arnd@arndb.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).