From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Amar Singhal <asinghal@codeaurora.org>,
Kiran Kumar Lokere <klokere@codeaurora.org>
Subject: Re: [PATCH 2/2] cfg80211: Modify wiphy registration semantics for self managed hints
Date: Wed, 21 Mar 2018 11:15:52 +0100 [thread overview]
Message-ID: <1521627352.2645.27.camel@sipsolutions.net> (raw)
In-Reply-To: <1520106021-16836-2-git-send-email-jouni@codeaurora.org>
So I really think this should just be one patch - it's not about
"registration semantics" but about which types of requests get passed
to reg_notifier(), and if you do it in one place you'd better also do
it in the other.
Secondly, this changes behaviour - not only for ath which presumably is
what you want, but also for
* brcmfmac
* brcmsmac
* libertas
* mwifiex
* mt76
* qtnfmac
* rtlwifi (& its staging cousin)
* rsi
* wlcore
* rtl8723bs (staging)
So I'm not really convinced we should do this unconditionally.
johannes
next prev parent reply other threads:[~2018-03-21 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 19:40 [PATCH 1/2] cfg80211: Enhance semantics for self-managed hints Jouni Malinen
2018-03-03 19:40 ` [PATCH 2/2] cfg80211: Modify wiphy registration semantics for self managed hints Jouni Malinen
2018-03-21 10:15 ` Johannes Berg [this message]
2018-04-13 20:32 ` asinghal
2018-04-19 15:07 ` Johannes Berg
2018-04-30 22:10 ` asinghal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521627352.2645.27.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=asinghal@codeaurora.org \
--cc=jouni@codeaurora.org \
--cc=klokere@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).