linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
	Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Subject: Re: [PATCHv4 2/3] mac80211: enable setting cqm rssi config for AP mode
Date: Fri, 23 Mar 2018 14:22:52 +0100	[thread overview]
Message-ID: <1521811372.11491.3.camel@sipsolutions.net> (raw)
In-Reply-To: <1519544998-2621-3-git-send-email-tamizhr@codeaurora.org> (sfid-20180225_085011_885309_75C5EC6D)

>  
> +static void ieee80211_update_rssi_config(struct
> ieee80211_sub_if_data *sdata)
> +{
> +	if (!(sdata->vif.driver_flags &
> IEEE80211_VIF_SUPPORTS_CQM_RSSI))
> +		return;
> +
> +	/* tell the driver upon association, unless already
> associated */
> +	if (sdata->vif.type == NL80211_IFTYPE_STATION &&
> +	    !sdata->u.mgd.associated)
> +		return;
> +
> +	/* if AP, always tell the driver by checking beacon status
> */
> +	if (!sdata->vif.bss_conf.enable_beacon ||
> +	    !wiphy_ext_feature_isset(sdata->local->hw.wiphy,
> +				NL80211_EXT_FEATURE_AP_STA_CQM_RSSI_
> CONFIG))
> +		return;

This probably should check for AP mode as well - not sure we use
enable_beacon for e.g. IBSS but I guess we could.

johannes

  reply	other threads:[~2018-03-23 13:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-25  7:49 [PATCHv4 0/3] cfg80211/mac80211: cqm rssi config for AP mode Tamizh chelvam
2018-02-25  7:49 ` [PATCHv4 1/3] cfg80211: enable setting " Tamizh chelvam
2018-03-23 13:27   ` Johannes Berg
2018-02-25  7:49 ` [PATCHv4 2/3] mac80211: " Tamizh chelvam
2018-03-23 13:22   ` Johannes Berg [this message]
2018-02-25  7:49 ` [PATCHv4 3/3] mac80211: implement cqm rssi check using rx data signal Tamizh chelvam
2018-03-23 13:24   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521811372.11491.3.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pradeepc@codeaurora.org \
    --cc=tamizhr@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).