From: Johannes Berg <johannes@sipsolutions.net>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCHv4 3/3] mac80211: implement cqm rssi check using rx data signal
Date: Fri, 23 Mar 2018 14:24:22 +0100 [thread overview]
Message-ID: <1521811462.11491.5.camel@sipsolutions.net> (raw)
In-Reply-To: <1519544998-2621-4-git-send-email-tamizhr@codeaurora.org> (sfid-20180225_085019_022021_682626EC)
> +/*
> + * How many frames need to have been used in average station's
> + * signal strength before checking against the threshold
> + */
> +#define IEEE80211_STA_SIGNAL_AVE_MIN_COUNT 4
This seems OK - you want something to start up from?
However, I don't think we do that in "normal" CQM, and building
different behaviour here seems a bit odd.
> + if (sig < thold && last_event == 0) {
> + sta->last_cqm_event_signal = sig;
> + cfg80211_ap_sta_cqm_rssi_notify(
> + rx->sdata->dev, sta->addr,
> + NL80211_CQM_RSSI_THRESHOLD_EVENT_LOW
> ,
> + sig, GFP_ATOMIC);
> + sta->count_rx_signal = 0;
In particular, resetting it all the time seems even stranger, since
then you can only react at a granularity of these 4 frames. EWMA
catches fluctuations already, so I don't think you should do it this
way.
johannes
prev parent reply other threads:[~2018-03-23 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 7:49 [PATCHv4 0/3] cfg80211/mac80211: cqm rssi config for AP mode Tamizh chelvam
2018-02-25 7:49 ` [PATCHv4 1/3] cfg80211: enable setting " Tamizh chelvam
2018-03-23 13:27 ` Johannes Berg
2018-02-25 7:49 ` [PATCHv4 2/3] mac80211: " Tamizh chelvam
2018-03-23 13:22 ` Johannes Berg
2018-02-25 7:49 ` [PATCHv4 3/3] mac80211: implement cqm rssi check using rx data signal Tamizh chelvam
2018-03-23 13:24 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521811462.11491.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).