linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@qca.qualcomm.com>,
	Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Steve deRosier <derosier@gmail.com>,
	Sunil Dutt Undekari <usdutt@qti.qualcomm.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Amarnath Hullur Subramanyam <amarnath@qti.qualcomm.com>,
	Rajesh Chauhan <rajeshc@qti.qualcomm.com>
Subject: Re: Wi-Fi Disconnection on Suspend for no wowlan triggers
Date: Thu, 05 Apr 2018 14:42:04 +0200	[thread overview]
Message-ID: <1522932124.7140.14.camel@sipsolutions.net> (raw)
In-Reply-To: <20180405112423.GA9248@jouni.qca.qualcomm.com>

On Thu, 2018-04-05 at 11:24 +0000, Jouni Malinen wrote:
> 
> The "any" trigger sounds like a reasonable thing to use, 

It really depends what you're after. The "any" trigger means you want to
wake up on all kinds of things, basically everything that would normally
give you an interrupt in regular operation.

> so the question
> really is on what the default behavior should be if the driver has
> capability of doing this and there is no explicit configuration in user
> space. Currently, the default behavior seems to be to force
> disconnection. Would it make sense to allow drivers to indicate that
> they rather use "any" trigger by default? Or make that the default
> behavior is the driver supports "any"?

I don't think that makes sense, TBH. Imagine how dire that situation
would be if you were to have that on your laptop, e.g. with iwlwifi
which in certain configurations can support "any" - you'd basically
never be able to suspend your system properly unless you disconnected
from wifi first!

> For example, wpa_supplicant does not currently set any trigger
> configuration unless explicitly asked to do so. 

Which, again, I think is best really.

> This in combination with
> the kernel default (disconnect) does not seem to result in desired
> behavior in number of Android cases.

So yeah, I guess I could see how on *Android* in particular you'd want a
different configuration - but there are enough ways to configure that on
Android systems in particular, whether by changing the wpa_supplicant
configuration (if it can do this) or by using libwifihal or similar
mechanisms.

Basically, I don't think changing it would make sense for a general
purpose default configuration - it's always a special case that you do
want to wake up on all kinds of wifi things happening.

johannes

      reply	other threads:[~2018-04-05 12:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 12:39 Wi-Fi Disconnection on Suspend for no wowlan triggers Sunil Dutt Undekari
2018-04-03 16:55 ` Steve deRosier
2018-04-04  6:11   ` Kalle Valo
2018-04-05  7:41   ` Arend van Spriel
2018-04-05  7:59     ` Johannes Berg
2018-04-05  8:07       ` Arend van Spriel
2018-04-05 11:24         ` Jouni Malinen
2018-04-05 12:42           ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522932124.7140.14.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=amarnath@qti.qualcomm.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=derosier@gmail.com \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rajeshc@qti.qualcomm.com \
    --cc=usdutt@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).