From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Dan Williams <dcbw@redhat.com>,
Brian Norris <briannorris@chromium.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
cjhuang@codeaurora.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH 2/2] ath10k: support MAC address randomization in scan
Date: Wed, 18 Apr 2018 11:58:37 +0200 [thread overview]
Message-ID: <1524045517.3024.3.camel@sipsolutions.net> (raw)
In-Reply-To: <5AD701F0.20504@broadcom.com> (sfid-20180418_102940_926003_EF96FC2A)
> > > Is there a problem with the "supported commands" list?
>
> My understanding is that in general the "supported commands" list is not
> well-maintained. Not every nl80211 command is represented in the list so
> user-space can not know whether it is missing or not supported.
> For this particular START_SCHED_SCAN command it can be used still and
> indeed probably for a long time. I just wanted to point out that it is
> not recommended for new user-space functionality.
We used to do it more, but most features are more complex than "command
is supported" or are simpler than "these 5 commands are supported" (just
a single bit to indicate the whole feature is enough), so we mostly use
extended feature flags now.
> > It sometimes feels like wpa_supplicant gets treated as a static entity
> > that can never be changed. In fact, send a patch to Jouni implementing
> > the best practice, with a fallback to preserve compat for old kernels,
> > and I'm sure he'd entertain it. Just because the supplicant does
> > something a certain way, doesn't mean it's the *best* way, but it too
> > evolves.
You also need to consider old supplicant on new kernels though? But I
didn't really follow this part of the discussion, so you're probably
taking that into account.
johannes
next prev parent reply other threads:[~2018-04-18 9:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 3:13 [PATCH 0/2] ath10k: support MAC address randomization in scan Carl Huang
2018-03-30 3:13 ` [PATCH 1/2] ath10k: Add WMI_SERVICE_AVAILABLE_EVENT support Carl Huang
2018-04-16 13:40 ` [1/2] " Kalle Valo
2018-04-24 5:46 ` Kalle Valo
2018-03-30 3:14 ` [PATCH 2/2] ath10k: support MAC address randomization in scan Carl Huang
2018-04-12 20:59 ` Brian Norris
2018-04-13 6:53 ` cjhuang
2018-04-13 11:28 ` Kalle Valo
2018-04-13 21:13 ` Arend van Spriel
2018-04-16 5:16 ` cjhuang
2018-04-16 11:32 ` Kalle Valo
2018-04-17 0:28 ` Brian Norris
2018-04-17 8:22 ` Arend van Spriel
2018-04-17 16:07 ` Brian Norris
2018-04-17 21:49 ` Arend van Spriel
2018-04-17 22:26 ` Brian Norris
2018-04-18 2:35 ` Dan Williams
2018-04-18 8:29 ` Arend van Spriel
2018-04-18 9:58 ` Johannes Berg [this message]
2018-04-16 5:17 ` cjhuang
2018-04-16 13:42 ` [2/2] " Kalle Valo
[not found] ` <20180416134238.B16596076A@smtp.codeaurora.org>
2018-04-17 7:29 ` cjhuang
2018-04-20 10:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524045517.3024.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=cjhuang@codeaurora.org \
--cc=dcbw@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).