linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Bernhard Gabler" <Bernhard_Gabler@web.de>,
	"Toke Høiland-Jørgensen" <toke@toke.dk>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] reg: Rename confusing 'country IE' in log output
Date: Fri, 20 Apr 2018 08:55:56 +0200	[thread overview]
Message-ID: <1524207356.23123.8.camel@sipsolutions.net> (raw)
In-Reply-To: <8ced0b02-af10-4d9d-9a68-cc08643a5cda@web.de>

On Fri, 2018-04-20 at 00:32 +0200, Bernhard Gabler wrote:

> looking at the patch, I see more occurences of the outdated "IE" in a 
> constant name and function name:
> 
>          case NL80211_REGDOM_SET_BY_COUNTRY_IE:
> or
>          reg_process_hint_country_ie()


Right. I searched for further strings that would show up to the user,
but didn't see any, but the code still refers to it in many places.

> Would it make sense to likewise fix these (and possibly more) 
> occurrences too, to match the spec from 2016?
> For the sake of readability and consistency of code ...

I dunno. Country IE isn't the only place where "IE" is used, it's even
used in struct names (struct ieee80211_tim_ie, and many others), so I
would think that people who actually work on the code will have to be
aware of the previous wording of "Information Element" (and the
abbreviation IE) anyway. Changing *everything* here to be just _element
instead of _ie or then probably the shorter _elem would IMHO be too much
code churn.

johannes

  reply	other threads:[~2018-04-20  6:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  9:17 [PATCH] reg: Rename confusing 'country IE' in log output Toke Høiland-Jørgensen
2018-04-19 22:32 ` Bernhard Gabler
2018-04-20  6:55   ` Johannes Berg [this message]
2018-04-20  9:12     ` Toke Høiland-Jørgensen
2018-04-23 19:10     ` mac80211: db3bdcb9c3ffc628c5284d7ed03a704295ba1214 breaks wds operation Sebastian Gottschall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524207356.23123.8.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Bernhard_Gabler@web.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).