From: Johannes Berg <johannes@sipsolutions.net>
To: Peter Oh <peter.oh@bowerswilkins.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mesh: don't process mesh channel switch unless csa ie provided
Date: Mon, 07 May 2018 22:06:42 +0200 [thread overview]
Message-ID: <1525723602.1080.0.camel@sipsolutions.net> (raw)
In-Reply-To: <81cf6620-d7f6-50f7-23c5-e1ba693f2907@bowerswilkins.com>
On Mon, 2018-05-07 at 13:04 -0700, Peter Oh wrote:
>
> On 05/07/2018 12:44 PM, Johannes Berg wrote:
> > On Fri, 2018-04-27 at 12:26 -0700, peter.oh@bowerswilkins.com wrote:
> > > From: Peter Oh <peter.oh@bowerswilkins.com>
> > >
> > > There is no meaning to call ieee80211_mesh_process_chnswitch
> > > without CSA IE provided, since the function will always return error.
> >
> > I'm not convinced, an extended channel switch element might be present
> > instead?
>
> I expected the comment. Yes, extended channel switch element could be
> present instead of channel switch element which I missed to take care
> of. So you can ignore the patch for now and I'll get back with right
> patch for it.
Heh. Well, but then why bother at all? I mean, the inner function will
do the check and fail, and nothing will happen, so why bother?
johannes
next prev parent reply other threads:[~2018-05-07 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 19:26 [PATCH] mesh: don't process mesh channel switch unless csa ie provided peter.oh
2018-05-07 19:44 ` Johannes Berg
2018-05-07 20:04 ` Peter Oh
2018-05-07 20:06 ` Johannes Berg [this message]
2018-05-07 20:28 ` Peter Oh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525723602.1080.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=peter.oh@bowerswilkins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox