From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([144.76.63.242]:41182 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934401AbeEIJAX (ORCPT ); Wed, 9 May 2018 05:00:23 -0400 Message-ID: <1525856418.6910.6.camel@sipsolutions.net> (sfid-20180509_110028_911459_65D5733E) Subject: Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes From: Johannes Berg To: Kalle Valo Cc: kbuild test robot , Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , kbuild-all@01.org, linux-wireless@vger.kernel.org, Maya Erez Date: Wed, 09 May 2018 11:00:18 +0200 In-Reply-To: <87tvrhw6kj.fsf@kamboji.qca.qualcomm.com> References: <201805090154.h4Cokbx2%fengguang.wu@intel.com> <87efil2p2o.fsf@purkki.adurom.net> <1525855900.6910.5.camel@sipsolutions.net> <87tvrhw6kj.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote: > Johannes Berg writes: > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote: > > > > > > I guess these warnings come because Toke's patch increased size of > > > struct cfg80211_tid_stats (which is included in struct station_info) and > > > both wil6210 and qtnfmac allocate a struct station_info from stack? > > > > Yes. > > > > > Can > > > someone send a fix for the drivers? > > > > I guess Toke/I should do that through my tree. > > IMHO the fix could go through my tree as well, less risk of conflicts in > drivers. AFAICS the fix (allocating station_info dynamically?) would not > depend on Toke's patch and could be applied separately. That's true, if you prefer that it's fine with me. johannes