From: Johannes Berg <johannes@sipsolutions.net>
To: Eric Biggers <ebiggers3@gmail.com>, linux-wireless@vger.kernel.org
Cc: syzbot <syzbot+e64565577af34b3768dc@syzkaller.appspotmail.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in dev_vprintk_emit
Date: Mon, 14 May 2018 14:13:47 +0200 [thread overview]
Message-ID: <1526300027.8070.0.camel@sipsolutions.net> (raw)
In-Reply-To: <20180513184714.GA677@sol.localdomain> (sfid-20180513_204509_876004_C99B826F)
On Sun, 2018-05-13 at 11:47 -0700, Eric Biggers wrote:
> The bug is that mac80211_hwsim allows creating device names that are too long,
> via HWSIM_CMD_NEW_RADIO. Commit a7cfebcb7594a2 ("cfg80211: limit wiphy names to
> 128 bytes") limited them to 128 bytes, but it's not enough because
> dev_vprintk_emit() needs the device name plus some other stuff to not exceed 128
> bytes. Here's a reproducer that works on Linus' tree (commit ccda3c4b777),
> provided that CONFIG_MAC80211_HWSIM=y. Note that you'll probably need to change
> the hardcoded MAC80211_HWSIM generic netlink family ID for it to work.
> Johannes, what would you say about limiting the name length to 64 bytes instead?
Don't really have any objections - care to send a patch?
johannes
next prev parent reply other threads:[~2018-05-14 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001a113a36724a053a0562f93c05@google.com>
2018-05-13 18:47 ` WARNING in dev_vprintk_emit Eric Biggers
2018-05-14 12:13 ` Johannes Berg [this message]
2018-05-15 3:09 ` [PATCH] cfg80211: further limit wiphy names to 64 bytes Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526300027.8070.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ebiggers3@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=syzbot+e64565577af34b3768dc@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).