From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Franky Lin <franky.lin@broadcom.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: [PATCH V2 6/6] brcmfmac: trigger memory dump on SDIO firmware halt message
Date: Wed, 16 May 2018 14:12:03 +0200 [thread overview]
Message-ID: <1526472723-15758-7-git-send-email-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <1526472723-15758-1-git-send-email-arend.vanspriel@broadcom.com>
From: Franky Lin <franky.lin@broadcom.com>
Attempt to dump dongle memory for debug upon receiving firmware halt
message through dongle to host mail box interrupt.
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 412a05b..c99a191 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -1072,8 +1072,10 @@ static u32 brcmf_sdio_hostmail(struct brcmf_sdio *bus)
bus->sdcnt.f1regdata += 2;
/* dongle indicates the firmware has halted/crashed */
- if (hmb_data & HMB_DATA_FWHALT)
+ if (hmb_data & HMB_DATA_FWHALT) {
brcmf_err("mailbox indicates firmware halted\n");
+ brcmf_dev_coredump(&sdiod->func1->dev);
+ }
/* Dongle recomposed rx frames, accept them again */
if (hmb_data & HMB_DATA_NAKHANDLED) {
--
1.9.1
prev parent reply other threads:[~2018-05-16 12:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 12:11 [PATCH V2 0/6] brcmfmac: coredump functionality and fixes Arend van Spriel
2018-05-16 12:11 ` [PATCH V2 1/6] brcmfmac: move ALLFFMAC variable in flowring module Arend van Spriel
2018-05-16 13:36 ` Kalle Valo
2018-05-23 15:54 ` [V2,1/6] " Kalle Valo
2018-05-16 12:11 ` [PATCH V2 2/6] brcmfmac: add support for sysfs initiated coredump Arend van Spriel
2018-05-16 12:12 ` [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump Arend van Spriel
2018-05-16 13:50 ` Kalle Valo
2018-05-16 18:52 ` Arend van Spriel
2018-05-21 8:19 ` [EXT] " Ganapathi Bhat
2018-05-23 7:54 ` Kalle Valo
2018-05-23 8:11 ` Arend van Spriel
2018-05-23 8:17 ` Kalle Valo
2018-05-23 11:24 ` Ganapathi Bhat
2018-05-23 15:56 ` Kalle Valo
2018-05-16 12:12 ` [PATCH V2 4/6] brcmfmac: validate user provided data for memdump before copying Arend van Spriel
2018-05-16 12:12 ` [PATCH V2 5/6] brcmfmac: trigger memory dump upon firmware halt signal Arend van Spriel
2018-05-16 12:12 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526472723-15758-7-git-send-email-arend.vanspriel@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).