From: Johannes Berg <johannes@sipsolutions.net>
To: Dedy Lansky <dlansky@codeaurora.org>,
'Jeff Johnson' <jjohnson@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event
Date: Tue, 22 May 2018 11:00:17 +0200 [thread overview]
Message-ID: <1526979617.6787.12.camel@sipsolutions.net> (raw)
In-Reply-To: <001201d3f0d4$93258900$b9709b00$@codeaurora.org>
On Mon, 2018-05-21 at 10:23 +0300, Dedy Lansky wrote:
> > We do, technically we should have something like nla_total_size() of various things including all those wiphy, ifindex, MAC attributes etc.
> > so we just get lazy...
>
> nla_total_size is currently not used in nl80211.c (actually not used
> in net\wireless\ for that matters).
Like I said, we're lazy ;-)
> IMO, switching nl80211/cfg80211 to use nla_total_size should be done
> separately.
I don't see much value in doing it at all, TBH.
johannes
prev parent reply other threads:[~2018-05-22 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 13:25 [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event Dedy Lansky
2018-05-17 18:43 ` Jeff Johnson
2018-05-17 19:29 ` Johannes Berg
2018-05-21 7:23 ` Dedy Lansky
2018-05-22 9:00 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526979617.6787.12.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dlansky@codeaurora.org \
--cc=jjohnson@codeaurora.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).