From: Johannes Berg <johannes@sipsolutions.net>
To: Omer Efrat <omer.efrat@tandemg.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] net: use BIT_ULL for NL80211_STA_INFO_* attribute types
Date: Wed, 13 Jun 2018 14:42:55 +0200 [thread overview]
Message-ID: <1528893775.1637.0.camel@sipsolutions.net> (raw)
In-Reply-To: <1528273621-28116-1-git-send-email-omer.efrat@tandemg.com> (sfid-20180606_102723_958302_FE904769)
On Wed, 2018-06-06 at 11:26 +0300, Omer Efrat wrote:
> Since 'filled' member in station_info changed to u64, BIT_ULL macro
> should be used with NL80211_STA_INFO_* attribute types instead of BIT.
>
> The BIT macro uses unsigned long type which some architectures handle as 32bit
> and this results in compilation warnings such as:
>
> net/mac80211/sta_info.c:2223:2: warning: left shift count >= width of type
> sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
> ^
>
> Signed-off-by: Omer Efrat <omer.efrat@tandemg.com>
>
Looks good, but can you please split it? I don't want to take batman
changes, and they probably don't want to take my mac80211 - unless davem
decides to take it all?
johannes
prev parent reply other threads:[~2018-06-13 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 8:26 [PATCH 1/3] net: use BIT_ULL for NL80211_STA_INFO_* attribute types Omer Efrat
2018-06-06 8:27 ` [PATCH 2/3] wireless-drivers: " Omer Efrat
2018-06-13 11:35 ` [2/3] " Kalle Valo
[not found] ` <20180613113507.B5F646074D@smtp.codeaurora.org>
2018-06-13 11:46 ` Omer Efrat
2018-06-06 8:27 ` [PATCH 3/3] staging: " Omer Efrat
2018-06-13 12:42 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528893775.1637.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=omer.efrat@tandemg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).