From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>
Cc: "McGinn, Dan" <dan.mcginn@imperial.ac.uk>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [BUG] mac80211: Using smp_processor_id() in preemptible code: iwd
Date: Wed, 20 Jun 2018 09:01:09 +0200 [thread overview]
Message-ID: <1529478069.3130.1.camel@sipsolutions.net> (raw)
In-Reply-To: <C7853888-5B20-4695-BD6F-4438B7ADF58D@gmail.com> (sfid-20180620_050502_120486_A63637FB)
On Tue, 2018-06-19 at 22:04 -0500, Denis Kenzior wrote:
>
> Right, but you’re much more aware of all the locking issues than I am.
:-)
> > Clearly this comes from cfg80211 without any locking other than rtnl, so
> > you don't have preemption disabled. That's the minimum needed to get rid
> > of the warning you found.
>
> In my defense, I did ask you whether there are any potential locking
> issues in the RFC and you didn’t think there were any.
Yep, I missed that too. More precisely, ISTR actually thinking about it
and deciding it was fine, so ... my bad for sure.
> I posted a fix for this. Could you please review?
I think it's fine. I'll make a pass later today/this week and send
patches upstream.
johannes
prev parent reply other threads:[~2018-06-20 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 11:09 [BUG] mac80211: Using smp_processor_id() in preemptible code: iwd McGinn, Dan
2018-06-15 12:30 ` Johannes Berg
2018-06-20 3:04 ` Denis Kenzior
2018-06-20 7:01 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529478069.3130.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dan.mcginn@imperial.ac.uk \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).