From: Johannes Berg <johannes@sipsolutions.net>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] mac80211: Add api to configure low and high txrate threshold
Date: Fri, 29 Jun 2018 11:45:22 +0200 [thread overview]
Message-ID: <1530265522.3481.52.camel@sipsolutions.net> (raw)
In-Reply-To: <1528887539-26821-3-git-send-email-tamizhr@codeaurora.org>
On Wed, 2018-06-13 at 16:28 +0530, Tamizh chelvam wrote:
> + if (sta->txrate_low == low_txrate_thold &&
> + sta->txrate_high == high_txrate_thold)
> + goto unlock;
> +
> + sta->txrate_low = low_txrate_thold;
> + sta->txrate_high = high_txrate_thold;
You don't really do anything here so what do you gain by doing the ==
comparison and jumping over the assignment?
I'd understand if you did some calculations here or whatever, but as it
is it reads more like something was missed than like it was intended
this way?
Again, I think you need to squash this with patch 4.
johannes
next prev parent reply other threads:[~2018-06-29 9:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 10:58 [PATCH 0/4] cfg80211/mac80211: Add support to configure and monitor txrate threshold Tamizh chelvam
2018-06-13 10:58 ` [PATCH 1/4] cfg80211: Add support to configure station specific " Tamizh chelvam
2018-06-29 9:44 ` Johannes Berg
2018-06-13 10:58 ` [PATCH 2/4] mac80211: Add api to configure low and high " Tamizh chelvam
2018-06-29 9:45 ` Johannes Berg [this message]
2018-06-13 10:58 ` [PATCH 3/4] cfg80211: Add support to notify station's txrate crossing event Tamizh chelvam
2018-06-29 9:46 ` Johannes Berg
2018-06-13 10:58 ` [PATCH 4/4] mac80211: Implement functionality to monitor txrate cross event for a station Tamizh chelvam
2018-06-29 9:47 ` Johannes Berg
2018-06-13 12:10 ` [PATCH 0/4] cfg80211/mac80211: Add support to configure and monitor txrate threshold Toke Høiland-Jørgensen
2018-06-13 14:24 ` Tamizh Chelvam Raja
2018-06-13 15:10 ` Toke Høiland-Jørgensen
2018-06-14 7:50 ` Arend van Spriel
2018-06-15 11:46 ` Janusz Dziedzic
2018-06-19 7:28 ` Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530265522.3481.52.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).