From: Ajay Singh <ajay.kathat@microchip.com>
To: <linux-wireless@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>,
<ganesh.krishna@microchip.com>, <venkateswara.kaja@microchip.com>,
<aditya.shankar@microchip.com>, <claudiu.beznea@microchip.com>,
<adham.abozaeid@microchip.com>,
Ajay Singh <ajay.kathat@microchip.com>
Subject: [PATCH 3/5] staging: wilc1000: remove the use of 'wilc_debugfs_info_t' struct
Date: Sun, 12 Aug 2018 10:17:43 +0530 [thread overview]
Message-ID: <1534049265-5600-4-git-send-email-ajay.kathat@microchip.com> (raw)
In-Reply-To: <1534049265-5600-1-git-send-email-ajay.kathat@microchip.com>
Refactor the code to remove the use of 'wilc_debugfs_info_t' struct.
Pass NULL for data in debugfs_create_file() call, as its value is not
used.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
drivers/staging/wilc1000/wilc_debugfs.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c b/drivers/staging/wilc1000/wilc_debugfs.c
index 78c0831..c9bc325 100644
--- a/drivers/staging/wilc1000/wilc_debugfs.c
+++ b/drivers/staging/wilc1000/wilc_debugfs.c
@@ -62,25 +62,10 @@ ssize_t wilc_debug_level_write(struct file *filp, const char __user *buf,
return count;
}
-struct wilc_debugfs_info_t {
- const char *name;
- int perm;
- unsigned int data;
-};
-
-static struct wilc_debugfs_info_t debugfs_info = {
- "wilc_debug_level",
- 0666,
- (DEBUG | ERR),
-};
-
int wilc_debugfs_init(const struct file_operations *fops)
{
- struct wilc_debugfs_info_t *info = &debugfs_info;
-
wilc_dir = debugfs_create_dir("wilc_wifi", NULL);
- debugfs_create_file(info->name, info->perm, wilc_dir, &info->data,
- fops);
+ debugfs_create_file("wilc_debug_level", 0666, wilc_dir, NULL, fops);
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2018-08-12 7:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 4:47 [PATCH 0/5] staging: wilc1000: compilation error fixes & cleanup changes Ajay Singh
2018-08-12 4:47 ` [PATCH 1/5] staging: wilc1000: avoid arrray of 'wilc_debugfs_info_t' type Ajay Singh
2018-08-12 11:29 ` Greg KH
2018-08-12 11:48 ` Ajay Singh
2018-08-12 15:24 ` Greg KH
2018-08-13 4:36 ` Ajay Singh
2018-08-12 4:47 ` [PATCH 2/5] staging: wilc1000: fixes for undefined reference to `__this_module' error Ajay Singh
2018-08-12 6:42 ` Greg KH
2018-08-12 11:22 ` Ajay Singh
2018-08-12 11:27 ` Greg KH
2018-08-12 11:35 ` Greg KH
2018-08-12 12:18 ` Ajay Singh
2018-08-12 15:23 ` Greg KH
2018-08-14 10:56 ` Dan Carpenter
2018-08-14 11:10 ` Arend van Spriel
2018-08-14 11:10 ` Ajay Singh
2018-08-12 4:47 ` Ajay Singh [this message]
2018-08-12 4:47 ` [PATCH 4/5] staging: wilc1000: change permission to 0600 in debugfs_create_file() call Ajay Singh
2018-08-12 11:36 ` Greg KH
2018-08-12 4:47 ` [PATCH 5/5] staging: wilc1000: use void return for wilc_debugfs_init() Ajay Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534049265-5600-4-git-send-email-ajay.kathat@microchip.com \
--to=ajay.kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).