Re: [PATCH] mac80211: ignore SA Query Requests with unknown payload data

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2018-08-14 at 13:16 +0200, Johannes Berg wrote:
> 
> > Since you change wpa_s to subscribe to the relevant action frame:
> > 
> > > +       /* SA Query Request */
> > > +       if (nl80211_register_action_frame(bss, (u8 *) "\x08\x00", 2) < 0)
> > > +               ret = -1;
> > 
> > we could change the logic to be
> > 
> > if (!frame_includes_OCV || !cfg80211_rx_mgmt(...))
> > 	respond_in_kernel();
> > 
> 
> An easier alternative might be to push ieee80211_process_sa_query_req()
> to after ieee80211_rx_h_userspace_mgmt() so it won't see the frames if
> userspace claimed them, but I'm not sure how that works in AP mode where
> hostapd claims all frames - though I guess these aren't relevant in AP
> mode?

However, then obviously wpa_s has to be able to handle them if OCV isn't
included, which I haven't checked. It probably should be able to anyway
though, since the frame might include other elements that aren't OCV,
causing the kernel to punt it to wpa_s.

johannes