From: Johannes Berg <johannes@sipsolutions.net>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
kernel-team@lge.com
Subject: Re: [PATCH 1/2] workqueue: skip lockdep wq dependency in cancel_work_sync()
Date: Wed, 22 Aug 2018 06:02:23 +0200 [thread overview]
Message-ID: <1534910543.25523.50.camel@sipsolutions.net> (raw)
In-Reply-To: <20180822024535.GA2414@X58A-UD3R>
On Wed, 2018-08-22 at 11:45 +0900, Byungchul Park wrote:
> That should've been adjusted as well when Ingo reverted Cross-release.
I can't really say.
> It would be much easier to add each pair, acquire/release, before
> wait_for_completion() in both flush_workqueue() and flush_work() than
> reverting the whole commit.
The commit doesn't do much more than this though.
> What's lacking is only lockdep annotations for wait_for_completion().
No, I disagree. Like I said before, we need the lockdep annotations on
the WQ even when we don't actually create/use the completion, so we can
catch issues even when they don't actually happen.
johannes
next prev parent reply other threads:[~2018-08-22 7:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 12:03 [PATCH 0/2] workqueue lockdep limitations/bugs Johannes Berg
2018-08-21 12:03 ` [PATCH 1/2] workqueue: skip lockdep wq dependency in cancel_work_sync() Johannes Berg
2018-08-21 16:08 ` Tejun Heo
2018-08-21 17:18 ` Johannes Berg
2018-08-21 17:27 ` Tejun Heo
2018-08-21 17:30 ` Johannes Berg
2018-08-21 17:55 ` Tejun Heo
2018-08-21 19:20 ` Johannes Berg
2018-08-22 2:45 ` Byungchul Park
2018-08-22 4:02 ` Johannes Berg [this message]
2018-08-22 5:47 ` Byungchul Park
2018-08-22 7:07 ` Johannes Berg
2018-08-22 7:50 ` Byungchul Park
2018-08-22 8:02 ` Johannes Berg
2018-08-22 9:15 ` Byungchul Park
2018-08-22 9:42 ` Johannes Berg
2018-08-22 12:47 ` Byungchul Park
2018-08-21 12:03 ` [PATCH 2/2] workqueue: create lockdep dependency in flush_work() Johannes Berg
2018-08-21 16:09 ` Tejun Heo
2018-08-21 17:19 ` Johannes Berg
2018-08-21 16:00 ` [PATCH 0/2] workqueue lockdep limitations/bugs Tejun Heo
2018-08-21 17:15 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534910543.25523.50.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=byungchul.park@lge.com \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).