linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Felix Fietkau <nbd@nbd.name>,
	sara.sharon@intel.com
Subject: Re: [PATCH] mac80211: do not aggregate frames if max_frags is set to one
Date: Wed, 29 Aug 2018 08:57:05 +0200	[thread overview]
Message-ID: <1535525825.5215.1.camel@sipsolutions.net> (raw)
In-Reply-To: <CAJ0CqmWLw11bmofttBfJQmNkCVhz-N3K9ah2HJkTbjZ6EDf-Xg@mail.gmail.com> (sfid-20180828_234116_503513_760A1610)

On Tue, 2018-08-28 at 23:41 +0200, Lorenzo Bianconi wrote:

> Assuming the A-MSDU subframe is composed by two packets, the last one
> must not contain padding, is my understanding correct?

Yes. More generally, assuming the A-MSDU subframe is composed of *any
number of* packets, the last one must not contain padding :)

> > My colleague Sara (CC'ed now) has a patch to fix all of this (we just
> > did that this morning). I'll send it out tomorrow morning. Can I bother
> > you to try that?
> > 
> 
> Sure, no worries :)

Thanks, patch coming up in a second.

> > We'd have to fix the first point independently though, or I guess we can
> > roll that into our bugfix too, which would you prefer?
> > 
> > johannes
> > 
> 
> If the patch is already done I can add the fix for the first point on
> top of it, does it sound good?

Perfect.

johannes

  reply	other threads:[~2018-08-29 10:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1535489707.git.lorenzo.bianconi@redhat.com>
2018-08-28 21:07 ` [PATCH] mac80211: do not aggregate frames if max_frags is set to one Lorenzo Bianconi
2018-08-28 21:14   ` Johannes Berg
2018-08-28 21:41     ` Lorenzo Bianconi
2018-08-29  6:57       ` Johannes Berg [this message]
2018-08-29 10:21         ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1535525825.5215.1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=sara.sharon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).