From: Johannes Berg <johannes@sipsolutions.net>
To: sanjay <sanjay.konduri@redpinesignals.com>,
Sushant Kumar Mishra <sushant2k1513@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>,
Sushant Kumar Mishra <sushant.mishra@redpinesignals.com>,
siva8118@gmail.com
Subject: Re: [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM
Date: Wed, 29 Aug 2018 09:24:10 +0200 [thread overview]
Message-ID: <1535527450.5215.8.camel@sipsolutions.net> (raw)
In-Reply-To: <5B83C2FE.90000@redpinesignals.com>
Huh, why did you send this like 10 times? Also, HTML is dropped by the
list ...
> > I'm not convinced - why would you set that? It seems to me that drivers
> > might, for example, still do one band in hardware and the other in
> > software, or something like that? You might also run into the WARN_ON
> > here?
>
> If we don't set this bit, observed "scan aborted" when "iw dev wlan0
> scan" command
> is given in redpine dual band modules(Didn't see any issue with single
> band module).
> sh# iw dev wlan0 scan
> scan aborted!
What happened underneath here? I'm having a hard time understanding -
perhaps you can at least capture some mac80211 event tracing for this?
perhaps with function graph tracing too, so we see where exactly the
abort happens.
Unless you already know why this happens, and that's why you set the
cancel bit?
So I think the clearer thing to do would be to have a separate bit for
this and check it in the right place.
johannes
next prev parent reply other threads:[~2018-08-29 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 3:30 [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM Sushant Kumar Mishra
2018-08-02 3:30 ` [PATCH v3 2/2] rsi: add support for hardware scan offload Sushant Kumar Mishra
2018-08-14 11:33 ` [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM Johannes Berg
[not found] ` <5B83C2FE.90000@redpinesignals.com>
2018-08-29 7:24 ` Johannes Berg [this message]
2018-08-31 13:34 ` Siva Rebbagondla
[not found] ` <1535970059.3437.39.camel@sipsolutions.net>
[not found] ` <CANGSkXTPejV11TVpauXn+t6g+rUQ8cYik8KAz7W1P-2Y-8XebA@mail.gmail.com>
[not found] ` <CANGSkXR11ZxFoiZ7sbKTu8BnXSpTsiAhH=DOD=e9Zh8bquDC0A@mail.gmail.com>
2018-09-11 12:25 ` Johannes Berg
2018-09-11 13:20 ` Siva Rebbagondla
2018-09-22 5:29 ` Siva Rebbagondla
2018-09-28 7:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535527450.5215.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sanjay.konduri@redpinesignals.com \
--cc=siva.rebbagondla@redpinesignals.com \
--cc=siva8118@gmail.com \
--cc=sushant.mishra@redpinesignals.com \
--cc=sushant2k1513@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).