From: Johannes Berg <johannes@sipsolutions.net>
To: Balaji Pothunoori <bpothuno@codeaurora.org>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ath10k: management tx ack rssi capability check
Date: Wed, 29 Aug 2018 10:53:14 +0200 [thread overview]
Message-ID: <1535532794.5215.20.camel@sipsolutions.net> (raw)
In-Reply-To: <1532006789-32454-4-git-send-email-bpothuno@codeaurora.org> (sfid-20180719_152706_974046_A35360D2)
On Thu, 2018-07-19 at 18:56 +0530, Balaji Pothunoori wrote:
>
>
> - if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map))
> + if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map) ||
> + test_bit(WMI_SERVICE_HTT_MGMT_TX_COMP_VALID_FLAGS, ar->wmi.svc_map))
> wiphy_ext_feature_set(ar->hw->wiphy,
> - NL80211_EXT_FEATURE_DATA_ACK_SIGNAL_SUPPORT);
> + NL80211_EXT_FEATURE_DATA_ACK_SIGNAL_SUPPORT);
You should use the new name, and fix indentation.
johannes
next prev parent reply other threads:[~2018-08-29 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 13:26 [PATCH v2 0/3] cfg80211/mac80211/ath10k: Extend avg ack rssi support for mgmt frames Balaji Pothunoori
2018-07-19 13:26 ` [PATCH v2 1/3] cfg80211: " Balaji Pothunoori
2018-07-19 13:26 ` [PATCH v2 2/3] mac80211: " Balaji Pothunoori
2018-07-19 13:26 ` [PATCH v2 3/3] ath10k: management tx ack rssi capability check Balaji Pothunoori
2018-08-29 8:53 ` Johannes Berg [this message]
2018-09-06 10:25 ` Balaji Pothunoori
2018-08-29 8:53 ` [PATCH v2 0/3] cfg80211/mac80211/ath10k: Extend avg ack rssi support for mgmt frames Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535532794.5215.20.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=bpothuno@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).