From: Johannes Berg <johannes@sipsolutions.net>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org,
Luca Coelho <luciano.coelho@intel.com>,
Naftali Goldstein <naftali.goldstein@intel.com>
Subject: Re: [PATCH 00/28] cfg80211/mac80211 patches from our internal tree 2018-08-31
Date: Mon, 03 Sep 2018 10:59:35 +0200 [thread overview]
Message-ID: <1535965175.3437.21.camel@sipsolutions.net> (raw)
In-Reply-To: <20180831083130.15525-1-luca@coelho.fi> (sfid-20180831_103149_730121_01876D5D)
Applied 2, 4, 8, 10, 11 as fixes.
Applied 1, 3, 5, 6, 7,
As Kalle pointed out, 20-28 are corrupted, so you need to resend; 22 was
already in the tree, no need to resend that one.
Please respin patch 20 ("mac80211: fix saving a few HE values") to use
FIELD_GET() to avoid such problems in the future. Or perhaps just use
le32_get_bits(), avoiding the explicit conversion first, I think the
compiler will probably do something sane either way.
While you're resending, please fix the kernel-doc in patch 19.
Please resend patches 9 and 12 as well, addressing my comments on it.
Still haven't looked at patch 12 because I remember some ordering issues
and need to double-check that.
johannes
next prev parent reply other threads:[~2018-09-03 13:18 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 8:31 [PATCH 00/28] cfg80211/mac80211 patches from our internal tree 2018-08-31 Luca Coelho
2018-08-31 8:31 ` [PATCH 01/28] mac80211: Add he_capa debugfs entry Luca Coelho
2018-08-31 8:31 ` [PATCH 02/28] mac80211: fix WMM TXOP calculation Luca Coelho
2018-08-31 8:31 ` [PATCH 03/28] mac80211: remove pointless 'params' NULL checks Luca Coelho
2018-08-31 8:31 ` [PATCH 04/28] mac80211: fix a race between restart and CSA flows Luca Coelho
2018-08-31 8:31 ` [PATCH 05/28] mac80211: use le16_encode_bits() instead of open-coding Luca Coelho
2018-08-31 8:31 ` [PATCH 06/28] mac80211: add an optional TXQ for other PS-buffered frames Luca Coelho
2018-08-31 8:31 ` [PATCH 07/28] ieee80211: remove redundant leading zeroes Luca Coelho
2018-08-31 8:31 ` [PATCH 08/28] mac80211: Fix station bandwidth setting after channel switch Luca Coelho
2018-08-31 8:31 ` [PATCH 09/28] mac80211: pass the TWT support bits in extended caps to the driver Luca Coelho
2018-09-03 8:52 ` Johannes Berg
2018-09-03 9:28 ` Grumbach, Emmanuel
2018-09-03 9:31 ` Johannes Berg
2018-09-03 9:38 ` Grumbach, Emmanuel
2018-08-31 8:31 ` [PATCH 10/28] mac80211: don't Tx a deauth frame if the AP forbade Tx Luca Coelho
2018-08-31 8:31 ` [PATCH 11/28] mac80211: shorten the IBSS debug messages Luca Coelho
2018-08-31 8:31 ` [PATCH 12/28] cfg80211: add he_capabilities (ext) IE to AP settings Luca Coelho
2018-09-03 8:56 ` Johannes Berg
2018-09-04 10:43 ` Luca Coelho
2018-09-04 11:03 ` Johannes Berg
2018-08-31 8:31 ` [PATCH 13/28] mac80211: in AP mode, set bss_conf::he_supported Luca Coelho
2018-08-31 8:31 ` [PATCH 14/28] ieee80211: add new VHT capability fields/parsing Luca Coelho
2018-08-31 8:31 ` [PATCH 15/28] mac80211: introduce capability flags for VHT EXT NSS support Luca Coelho
2018-08-31 8:31 ` [PATCH 16/28] mac80211: add ability to parse CCFS2 Luca Coelho
2018-08-31 8:31 ` [PATCH 17/28] mac80211: copy VHT EXT NSS BW Support/Capable data to station Luca Coelho
2018-08-31 8:31 ` [PATCH 18/28] mac80211: support radiotap L-SIG data Luca Coelho
2018-08-31 8:31 ` [PATCH 19/28] mac80211: support reporting 0-length PSDU in radiotap Luca Coelho
2018-09-01 7:37 ` kbuild test robot
2018-08-31 8:31 ` [PATCH 20/28] mac80211: fix saving a few HE values Luca Coelho
2018-08-31 8:31 ` [PATCH 21/28] wireless: align to draft 11ax D3.0 Luca Coelho
2018-08-31 11:18 ` Kalle Valo
2018-08-31 11:21 ` Kalle Valo
2018-08-31 13:58 ` Luca Coelho
2018-08-31 8:31 ` [PATCH 22/28] mac80211: avoid kernel panic when building AMSDU from non-linear SKB Luca Coelho
2018-08-31 8:31 ` [PATCH 23/28] mac80211: add an option for station management TXQ Luca Coelho
2018-08-31 8:31 ` [PATCH 24/28] mac80211: allow AMSDU size limitation per-TID Luca Coelho
2018-08-31 8:31 ` [PATCH 25/28] mac80211: add an option for drivers to check if packets can be aggregated Luca Coelho
2018-08-31 8:31 ` [PATCH 26/28] cfg80211: reg: Init wiphy_idx in regulatory_hint_core() Luca Coelho
2018-08-31 8:31 ` [PATCH 27/28] mac80211: Always report TX status Luca Coelho
2018-08-31 8:31 ` [PATCH 28/28] mac80211: Don't wake up from PS for offchannel TX Luca Coelho
2018-08-31 18:21 ` Peter Oh
2018-08-31 19:02 ` Luca Coelho
2018-09-03 8:59 ` Johannes Berg [this message]
2018-09-04 11:40 ` [PATCH v2 0/9] cfg80211/mac80211: reworked patches from our internal tree 2018-08-31 Luca Coelho
2018-09-04 11:40 ` [PATCH v2 1/9] mac80211: support reporting 0-length PSDU in radiotap Luca Coelho
2018-09-04 11:40 ` [PATCH v2 2/9] mac80211: fix saving a few HE values Luca Coelho
2018-09-04 11:40 ` [PATCH v2 3/9] wireless: align to draft 11ax D3.0 Luca Coelho
2018-09-04 11:40 ` [PATCH v2 4/9] mac80211: add an option for station management TXQ Luca Coelho
2018-09-04 11:40 ` [PATCH v2 5/9] mac80211: allow AMSDU size limitation per-TID Luca Coelho
2018-09-04 11:40 ` [PATCH v2 6/9] mac80211: add an option for drivers to check if packets can be aggregated Luca Coelho
2018-09-04 11:40 ` [PATCH v2 7/9] cfg80211: reg: Init wiphy_idx in regulatory_hint_core() Luca Coelho
2018-09-04 11:40 ` [PATCH v2 8/9] mac80211: Always report TX status Luca Coelho
2018-09-04 11:40 ` [PATCH v2 9/9] mac80211: Don't wake up from PS for offchannel TX Luca Coelho
2018-09-04 12:07 ` Sven Eckelmann
2018-09-04 12:10 ` Johannes Berg
2018-09-04 12:13 ` Luca Coelho
2018-09-04 12:16 ` Sven Eckelmann
2018-09-05 5:06 ` [RESEND PATCH v2 0/9] cfg80211/mac80211: reworked patches from our internal tree 2018-08-31 Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 1/9] mac80211: support reporting 0-length PSDU in radiotap Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 2/9] mac80211: fix saving a few HE values Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 3/9] wireless: align to draft 11ax D3.0 Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 4/9] mac80211: add an option for station management TXQ Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 5/9] mac80211: allow AMSDU size limitation per-TID Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 6/9] mac80211: add an option for drivers to check if packets can be aggregated Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 7/9] cfg80211: reg: Init wiphy_idx in regulatory_hint_core() Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 8/9] mac80211: Always report TX status Luca Coelho
2018-09-05 5:06 ` [RESEND PATCH v2 9/9] mac80211: Don't wake up from PS for offchannel TX Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535965175.3437.21.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
--cc=naftali.goldstein@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).