From: Johannes Berg <johannes@sipsolutions.net>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
David Spinadel <david.spinadel@intel.com>
Subject: Re: [PATCH v2 2/3] mac80211: support FTM responder configuration/statistics
Date: Mon, 03 Sep 2018 11:33:45 +0200 [thread overview]
Message-ID: <1535967225.3437.27.camel@sipsolutions.net> (raw)
In-Reply-To: <1535745418-31336-3-git-send-email-pradeepc@codeaurora.org>
On Fri, 2018-08-31 at 12:56 -0700, Pradeep Kumar Chitrapu wrote:
>
> + * @ftm_responder: whether to enable fine timing measurement FTM functionality
missing "responder" somewhere there :)
> + * @ftmr_params: configurable lci/civic parameter when enabling FTM responder.
Perhaps the *existence* of ftmr_params could indicate that it's enabled?
> @@ -865,6 +899,20 @@ static int ieee80211_assign_beacon(struct ieee80211_sub_if_data *sdata,
> if (err == 0)
> changed |= BSS_CHANGED_AP_PROBE_RESP;
>
> + if (params->ftm_responder) {
Here you immediately have the problem I talked about in the earlier
patch ... yes, we don't have drivers that allow disabling it (so should
probably reject that now), but without it you can *enable* it on the
fly, but you cannot *disable*, in fact we assume saying "disable" means
"no change" which is rather confusing.
johannes
next prev parent reply other threads:[~2018-09-03 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 19:56 [PATCH v2 0/3] support ftm responder configuration/statistics Pradeep Kumar Chitrapu
2018-08-31 19:56 ` [PATCH v2 1/3] cfg80211: support FTM " Pradeep Kumar Chitrapu
2018-09-03 9:29 ` Johannes Berg
2018-08-31 19:56 ` [PATCH v2 2/3] mac80211: " Pradeep Kumar Chitrapu
2018-09-03 9:33 ` Johannes Berg [this message]
2018-09-06 1:06 ` Pradeep Kumar Chitrapu
2018-09-06 6:39 ` Johannes Berg
2018-08-31 19:56 ` [PATCH v2 3/3] ath10k: Add support to configure ftm responder role Pradeep Kumar Chitrapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535967225.3437.27.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=david.spinadel@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).