From: Ajay Singh <ajay.kathat@microchip.com>
To: <linux-wireless@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>,
<ganesh.krishna@microchip.com>, <venkateswara.kaja@microchip.com>,
<aditya.shankar@microchip.com>, <claudiu.beznea@microchip.com>,
<adham.abozaeid@microchip.com>,
Ajay Singh <ajay.kathat@microchip.com>
Subject: [PATCH v2 08/26] staging: wilc1000: avoid use of extra 'if' condition in wilc_init()
Date: Tue, 4 Sep 2018 12:09:24 +0530 [thread overview]
Message-ID: <1536043182-19735-9-git-send-email-ajay.kathat@microchip.com> (raw)
In-Reply-To: <1536043182-19735-1-git-send-email-ajay.kathat@microchip.com>
Cleanup patch to avoid the avoid extra 'if' condition and clubbed the
same condition in single 'if' block.
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
drivers/staging/wilc1000/host_interface.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 11eb632..6225e67 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3459,9 +3459,7 @@ int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
if (clients_count == 0) {
init_completion(&hif_driver_comp);
mutex_init(&hif_deinit_lock);
- }
- if (clients_count == 0) {
hif_workqueue = create_singlethread_workqueue("WILC_wq");
if (!hif_workqueue) {
netdev_err(vif->ndev, "Failed to create workqueue\n");
--
2.7.4
next prev parent reply other threads:[~2018-09-04 11:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 6:39 [PATCH v2 00/26] staging: wilc1000: avoid use of static and global variable Ajay Singh
2018-09-04 6:39 ` [PATCH v2 01/26] staging: wilc1000: move 'wilc_enable_ps' global variable into 'wilc' struct Ajay Singh
2018-09-04 6:39 ` [PATCH v2 02/26] staging: wilc1000: move 'aging_timer' static variable to wilc_priv struct Ajay Singh
2018-09-04 6:39 ` [PATCH v2 03/26] staging: wilc1000: fix to use correct index to free scanned info in clear_shadow_scan() Ajay Singh
2018-09-04 6:39 ` [PATCH v2 04/26] staging: wilc1000: remove unnecessary NULL check " Ajay Singh
2018-09-04 6:39 ` [PATCH v2 05/26] staging: wilc1000: moved last_scanned_shadow & last_scanned_cnt to wilc_priv struct Ajay Singh
2018-09-04 6:39 ` [PATCH v2 06/26] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct Ajay Singh
2018-09-04 6:39 ` [PATCH v2 07/26] staging: wilc1000: remove unused variable 'op_ifcs' Ajay Singh
2018-09-04 6:39 ` Ajay Singh [this message]
2018-09-04 6:39 ` [PATCH v2 09/26] staging: wilc1000: move static variable clients_count to 'wilc' structure Ajay Singh
2018-09-04 6:39 ` [PATCH v2 10/26] staging: wilc1000: refactor code to avoid use of wilc_set_multicast_list global Ajay Singh
2018-09-04 6:39 ` [PATCH v2 11/26] staging: wilc1000: move hif_workqueue static variables to 'wilc' structure Ajay Singh
2018-09-04 6:39 ` [PATCH v2 12/26] staging: wilc1000: move 'periodic_rssi' as part of 'wilc_vif' struct Ajay Singh
2018-09-04 6:39 ` [PATCH v2 13/26] staging: wilc1000: rename 'dummy_statistics' variable to 'periodic_stat' Ajay Singh
2018-09-04 6:39 ` [PATCH v2 14/26] staging: wilc1000: move 'rcv_assoc_resp' as part of hif_drv Ajay Singh
2018-09-04 6:39 ` [PATCH v2 15/26] staging: wilc1000: refactor tcp_process() to avoid extra leading tabs Ajay Singh
2018-09-04 6:39 ` [PATCH v2 16/26] staging: wilc1000: use lowercase for get_BSSID() and HIL variable Ajay Singh
2018-09-04 6:39 ` [PATCH v2 17/26] staging: wilc1000: move tcp_ack_filter algo related variables to 'wilc_vif' struct Ajay Singh
2018-09-04 6:39 ` [PATCH v2 18/26] staging: wilc1000: avoid line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack() Ajay Singh
2018-09-04 6:39 ` [PATCH v2 19/26] staging: wilc1000: use short names to fix over 80 issue in tcp_process() Ajay Singh
2018-09-04 6:39 ` [PATCH v2 20/26] staging: wilc1000: remove unused code to set and get IP address Ajay Singh
2018-09-04 6:39 ` [PATCH v2 21/26] staging: wilc1000: move 'chip_ps_state' static variable as part of 'wilc' struct Ajay Singh
2018-09-04 6:39 ` [PATCH v2 22/26] staging: wilc1000: move 'wilc_connecting' static variable to 'wilc_vif' struct Ajay Singh
2018-09-04 6:39 ` [PATCH v2 23/26] staging: wilc1000: remove unnecessary static variable 'p2p_listen_state' Ajay Singh
2018-09-04 6:39 ` [PATCH v2 24/26] staging: wilc1000: refactor code to move initilization in wilc_netdev_init() Ajay Singh
2018-09-04 6:39 ` [PATCH v2 25/26] staging: wilc1000: refactor wilc_netdev_init() to handle memory free in error path Ajay Singh
2018-09-11 9:21 ` Claudiu Beznea
2018-09-10 14:24 ` Ajay Singh
2018-09-04 6:39 ` [PATCH v2 26/26] staging: wilc1000: remove handle_hif_exit_work() function Ajay Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536043182-19735-9-git-send-email-ajay.kathat@microchip.com \
--to=ajay.kathat@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).