From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org
Cc: "Felix Fietkau" <nbd@nbd.name>, "Toke Høiland-Jørgensen" <toke@toke.dk>
Subject: Re: [PATCH] mac80211: use non-zero TID only for QoS frames
Date: Wed, 05 Sep 2018 10:09:35 +0200 [thread overview]
Message-ID: <1536134975.3528.0.camel@sipsolutions.net> (raw)
In-Reply-To: <5B8F8E83.1090707@broadcom.com> (sfid-20180905_100631_619747_8CED9977)
On Wed, 2018-09-05 at 10:06 +0200, Arend van Spriel wrote:
>
> > +++ b/net/mac80211/tx.c
> > @@ -1260,7 +1260,10 @@ static struct txq_info *ieee80211_get_txq(struct ieee80211_local *local,
> > txq = sta->sta.txq[IEEE80211_NUM_TIDS];
> > }
> > } else if (sta) {
> > - u8 tid = skb->priority & IEEE80211_QOS_CTL_TID_MASK;
> > + u8 tid = 0;
> > +
> > + if (hdr->frame_control & cpu_to_le16(IEEE80211_STYPE_QOS_DATA))
> > + tid = skb->priority & IEEE80211_QOS_CTL_TAG1D_MASK;
>
> Is the use of different mask intentional here? Just a quick glance so
> did not look into it further.
Ah, I forgot to mention that in the commit log. That just aligns it with
most of the other code, but since we never have values other than 0-7 it
doesn't actually matter.
johannes
next prev parent reply other threads:[~2018-09-05 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 8:00 [PATCH] mac80211: use non-zero TID only for QoS frames Johannes Berg
2018-09-05 8:06 ` Arend van Spriel
2018-09-05 8:09 ` Johannes Berg [this message]
2018-09-05 9:47 ` Toke Høiland-Jørgensen
2018-09-05 9:50 ` Johannes Berg
2018-09-05 9:56 ` Toke Høiland-Jørgensen
2018-09-05 10:56 ` Johannes Berg
2018-09-05 11:07 ` Toke Høiland-Jørgensen
2018-09-05 11:08 ` Johannes Berg
2018-09-05 11:12 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536134975.3528.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).