From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>, "Felix Fietkau" <nbd@nbd.name>
Subject: Re: [PATCH] mac80211: TDLS: fix skb queue/priority assignment
Date: Wed, 05 Sep 2018 13:37:33 +0200 [thread overview]
Message-ID: <1536147453.3528.11.camel@sipsolutions.net> (raw)
In-Reply-To: <20180905113402.7665-1-johannes@sipsolutions.net> (sfid-20180905_133416_297971_AFC86F42)
On Wed, 2018-09-05 at 13:34 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> If the TDLS setup happens over a connection to an AP that
> doesn't have QoS, we nevertheless assign a non-zero TID
> (skb->priority) and queue mapping, which may confuse us or
> drivers later.
>
> Fix it by just assigning the special skb->priority and then
> using ieee80211_select_queue() just like other data frames
> would go through.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> OK, this addresses the case I was worried about - perhaps
> better take this than the txq patch?
I really only found this. All the other cases aren't doing real data
frames, only null-data and management. So I guess for those we're OK,
and this was the only special case after all.
johannes
next prev parent reply other threads:[~2018-09-05 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 11:34 [PATCH] mac80211: TDLS: fix skb queue/priority assignment Johannes Berg
2018-09-05 11:37 ` Johannes Berg [this message]
2018-09-05 11:40 ` Toke Høiland-Jørgensen
2018-09-05 11:41 ` Johannes Berg
2018-09-05 11:44 ` Johannes Berg
2018-09-05 12:32 ` Toke Høiland-Jørgensen
2018-09-05 12:33 ` Johannes Berg
2018-09-05 12:50 ` Toke Høiland-Jørgensen
2018-09-28 7:17 ` Johannes Berg
2018-09-28 9:04 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536147453.3528.11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).