From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Problem with sending pkt on a monitor port
Date: Thu, 20 Sep 2018 09:31:35 +0200 [thread overview]
Message-ID: <1537428695.3874.1.camel@sipsolutions.net> (raw)
In-Reply-To: <d6f99a05-77a3-f18a-4e7a-083062119ce4@candelatech.com>
On Wed, 2018-09-19 at 13:47 -0700, Ben Greear wrote:
> > For one, the driver has no concept of the original vif, since monitor
> > vifs aren't added to it.
>
> ath10k does create a monitor vif, but maybe it is not mapped directly
> to mac80211.
It's actually created by mac80211, but only once, and not directly
mapped to each vif seen by userspace - it's an internal construction.
> > Secondly, the old hostapd code before nl80211 injects frames that way,
> > and they need to go there.
>
> Ok, I agree we should not break backwards compat then. I'll poke some more
> to see if I can get it working.
We might get away with doing this only for cooked monitor mode, which it
used there ...
However, thinking about it, that also breaks userspace in other ways -
for example if you do injection this way you actually get encryption and
other nice things if you use the local address that matches an existing
interface.
Perhaps you should just use a different address, and then nothing of the
sort would happen?
johannes
next prev parent reply other threads:[~2018-09-20 13:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 20:33 Problem with sending pkt on a monitor port Ben Greear
2018-09-19 20:35 ` Johannes Berg
2018-09-19 20:47 ` Ben Greear
2018-09-20 7:31 ` Johannes Berg [this message]
2018-09-20 14:26 ` Ben Greear
2018-09-28 7:14 ` Johannes Berg
2018-09-28 15:22 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537428695.3874.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).