linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: How many null-data probes on connection loss?
Date: Wed, 26 Sep 2018 20:26:55 +0200	[thread overview]
Message-ID: <1537986415.28767.17.camel@sipsolutions.net> (raw)
In-Reply-To: <fc564b2e-b6f2-75db-a2d9-99ea55a63c4a@candelatech.com>

On Wed, 2018-09-26 at 11:04 -0700, Ben Greear wrote:

> I have been running with mac80211/mlme.c's max_nullfunc_tries set to 5 for many years.
> Long ago it helped with connectivity issues with lots of vdevs and and/orloaded APs
> if I recall correctly.

That's different, that's the number of distinct frames mac80211 will
send.

I thought you were asking about *retries*.

> In fact, I see 62 frames captured on air all with the same sequence number
> in the test I just did, and subsequent frames with the next seq-no are sent
> immediately after the first one.  The frames are all right after each other, so
> I guess this is probably firmware doing lots of HW retransmits and then *also*
> doing software retransmits in the firmware (my reading of mlme.c indicates it should
> only probe every 500ms).

Yes.

> I think I'll start by making sure the firmware does not do software retransmits
> for frames from the driver (self-gen frames are OK to be retransmitted I guess).

You do want it to be doing retries for frames from the driver, since you
want it to recover from temporary collisions with a microwave and
whatnot ... just not *that many*, I guess.

johannes

  reply	other threads:[~2018-09-26 18:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 23:12 How many null-data probes on connection loss? Ben Greear
2018-09-26  8:38 ` Johannes Berg
2018-09-26 18:04   ` Ben Greear
2018-09-26 18:26     ` Johannes Berg [this message]
2018-09-26 18:47       ` Ben Greear
2018-09-26 18:48         ` Johannes Berg
2018-09-26 18:53           ` Ben Greear
2018-09-26 22:21           ` Ben Greear
2018-09-27  7:12             ` Johannes Berg
2018-09-27 15:32               ` Ben Greear
2018-09-28  7:19                 ` Johannes Berg
2018-09-28 15:14                   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1537986415.28767.17.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).