From: Pkshih <pkshih@realtek.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"zhangshaokun@hisilicon.com" <zhangshaokun@hisilicon.com>
Cc: "kvalo@codeaurora.org" <kvalo@codeaurora.org>
Subject: Re: [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information
Date: Tue, 6 Nov 2018 01:57:09 +0000 [thread overview]
Message-ID: <1541469426.3804.0.camel@realtek.com> (raw)
In-Reply-To: <1541417130-9898-1-git-send-email-zhangshaokun@hisilicon.com>
On Mon, 2018-11-05 at 19:25 +0800, Shaokun Zhang wrote:
> RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x'
> prefix, which is somewhat misleading.
>
> Fix it to print hexadecimal, as was intended.
>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> index 85cedd0..75bfa9d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> @@ -173,7 +173,7 @@ static int _rtl92d_fw_init(struct ieee80211_hw *hw)
> rtl_read_byte(rtlpriv, FW_MAC1_READY));
> }
> RT_TRACE(rtlpriv, COMP_FW, DBG_DMESG,
> - "Polling FW ready fail!! REG_MCUFWDL:0x%08ul\n",
> + "Polling FW ready fail!! REG_MCUFWDL:0x%08x\n",
> rtl_read_dword(rtlpriv, REG_MCUFWDL));
> return -1;
> }
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Thanks for your fix.
next prev parent reply other threads:[~2018-11-06 1:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 11:25 [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information Shaokun Zhang
2018-11-06 1:57 ` Pkshih [this message]
2018-11-06 17:05 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541469426.3804.0.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).