* [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information
@ 2018-11-05 11:25 Shaokun Zhang
2018-11-06 1:57 ` Pkshih
2018-11-06 17:05 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Shaokun Zhang @ 2018-11-05 11:25 UTC (permalink / raw)
To: linux-wireless; +Cc: Shaokun Zhang, Ping-Ke Shih, Kalle Valo
RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x'
prefix, which is somewhat misleading.
Fix it to print hexadecimal, as was intended.
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
index 85cedd0..75bfa9d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
@@ -173,7 +173,7 @@ static int _rtl92d_fw_init(struct ieee80211_hw *hw)
rtl_read_byte(rtlpriv, FW_MAC1_READY));
}
RT_TRACE(rtlpriv, COMP_FW, DBG_DMESG,
- "Polling FW ready fail!! REG_MCUFWDL:0x%08ul\n",
+ "Polling FW ready fail!! REG_MCUFWDL:0x%08x\n",
rtl_read_dword(rtlpriv, REG_MCUFWDL));
return -1;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information
2018-11-05 11:25 [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information Shaokun Zhang
@ 2018-11-06 1:57 ` Pkshih
2018-11-06 17:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Pkshih @ 2018-11-06 1:57 UTC (permalink / raw)
To: linux-wireless@vger.kernel.org, zhangshaokun@hisilicon.com
Cc: kvalo@codeaurora.org
On Mon, 2018-11-05 at 19:25 +0800, Shaokun Zhang wrote:
> RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x'
> prefix, which is somewhat misleading.
>
> Fix it to print hexadecimal, as was intended.
>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> index 85cedd0..75bfa9d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> @@ -173,7 +173,7 @@ static int _rtl92d_fw_init(struct ieee80211_hw *hw)
> rtl_read_byte(rtlpriv, FW_MAC1_READY));
> }
> RT_TRACE(rtlpriv, COMP_FW, DBG_DMESG,
> - "Polling FW ready fail!! REG_MCUFWDL:0x%08ul\n",
> + "Polling FW ready fail!! REG_MCUFWDL:0x%08x\n",
> rtl_read_dword(rtlpriv, REG_MCUFWDL));
> return -1;
> }
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Thanks for your fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information
2018-11-05 11:25 [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information Shaokun Zhang
2018-11-06 1:57 ` Pkshih
@ 2018-11-06 17:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-11-06 17:05 UTC (permalink / raw)
To: Shaokun Zhang; +Cc: linux-wireless, Shaokun Zhang, Ping-Ke Shih
Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
> RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x'
> prefix, which is somewhat misleading.
>
> Fix it to print hexadecimal, as was intended.
>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
7d129adff3af rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information
--
https://patchwork.kernel.org/patch/10667863/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-06 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-05 11:25 [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information Shaokun Zhang
2018-11-06 1:57 ` Pkshih
2018-11-06 17:05 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).