From: Maya Erez <merez@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Maya Erez <merez@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: [PATCH 7/9] wil6210: fix missed MISC mbox interrupt
Date: Fri, 26 Apr 2019 18:43:35 +0300 [thread overview]
Message-ID: <1556293417-27097-8-git-send-email-merez@codeaurora.org> (raw)
In-Reply-To: <1556293417-27097-1-git-send-email-merez@codeaurora.org>
When MISC interrupt is triggered due to HALP bit, in parallel
to mbox events handling by the MISC threaded IRQ, new mbox
interrupt can be missed in the following scenario:
1. MISC ICR is read in the IRQ handler
2. Threaded IRQ is completed and all MISC interrupts are unmasked
3. mbox interrupt is set by FW
4. HALP is masked
The mbox interrupt in step 3 can be missed due to constant high level
of ICM.
Masking all MISC IRQs instead of masking only HALP bit in step 4
will guarantee that ICM will drop to 0 and interrupt will be triggered
once MISC interrupts will be unmasked.
Signed-off-by: Maya Erez <merez@codeaurora.org>
---
drivers/net/wireless/ath/wil6210/interrupt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wil6210/interrupt.c b/drivers/net/wireless/ath/wil6210/interrupt.c
index d161dc9..b00a13d 100644
--- a/drivers/net/wireless/ath/wil6210/interrupt.c
+++ b/drivers/net/wireless/ath/wil6210/interrupt.c
@@ -595,7 +595,7 @@ static irqreturn_t wil6210_irq_misc(int irq, void *cookie)
/* no need to handle HALP ICRs until next vote */
wil->halp.handle_icr = false;
wil_dbg_irq(wil, "irq_misc: HALP IRQ invoked\n");
- wil6210_mask_halp(wil);
+ wil6210_mask_irq_misc(wil, true);
complete(&wil->halp.comp);
}
}
--
1.9.1
next prev parent reply other threads:[~2019-04-26 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 15:43 [PATCH 0/9] wil6210 patches Maya Erez
2019-04-26 15:43 ` [PATCH 1/9] wil6210: fix spurious interrupts in 3-msi Maya Erez
2019-05-03 5:05 ` Kalle Valo
2019-04-26 15:43 ` [PATCH 2/9] wil6210: fix _desc access in __wil_tx_vring_tso Maya Erez
2019-04-26 15:43 ` [PATCH 3/9] wil6210: add printout of platform capabilities Maya Erez
2019-04-26 15:43 ` [PATCH 4/9] wil6210: add support for multiple sections in brd file Maya Erez
2019-04-26 15:43 ` [PATCH 5/9] wil6210: enhancements for descriptor and status ring debugfs Maya Erez
2019-04-26 15:43 ` [PATCH 6/9] wil6210: fix overwriting max_assoc_sta module param Maya Erez
2019-04-26 15:43 ` Maya Erez [this message]
2019-04-26 15:43 ` [PATCH 8/9] wil6210: check rx_buff_mgmt before accessing it Maya Erez
2019-04-26 15:43 ` [PATCH 9/9] wil6210: remove HALP for Talyn devices Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556293417-27097-8-git-send-email-merez@codeaurora.org \
--to=merez@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).