From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A0AC04AB6 for ; Fri, 31 May 2019 10:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 127E72677A for ; Fri, 31 May 2019 10:31:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbfEaKbh (ORCPT ); Fri, 31 May 2019 06:31:37 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:50287 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726233AbfEaKbh (ORCPT ); Fri, 31 May 2019 06:31:37 -0400 X-UUID: ad0d1c2b08554872854e3b038420a56c-20190531 X-UUID: ad0d1c2b08554872854e3b038420a56c-20190531 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 661529757; Fri, 31 May 2019 18:31:28 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 31 May 2019 18:31:27 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 31 May 2019 18:31:21 +0800 Message-ID: <1559298681.3296.3.camel@mtkswgap22> Subject: Re: [PATCH 1/2] mt76: mt7615: enable support for mesh From: Ryder Lee To: Lorenzo Bianconi CC: Felix Fietkau , Lorenzo Bianconi , Roy Luo , YF Luo , Yiwei Chung , Sean Wang , Chih-Min Chen , , , Date: Fri, 31 May 2019 18:31:21 +0800 In-Reply-To: <20190531100201.GA3527@localhost.localdomain> References: <7f167d09736652f81383991c971506630bbedacc.1559287432.git.ryder.lee@mediatek.com> <20190531100201.GA3527@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2019-05-31 at 12:02 +0200, Lorenzo Bianconi wrote: > > Enable NL80211_IFTYPE_MESH_POINT and add its path. > > > > Signed-off-by: Ryder Lee > > --- > > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 6 ++++++ > > drivers/net/wireless/mediatek/mt76/mt7615/main.c | 1 + > > drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 5 ++++- > > 3 files changed, 11 insertions(+), 1 deletion(-) > > > > [...] > > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c b/drivers/net/wireless/mediatek/mt76/mt7615/main.c > > index b0bb7cc12385..585e67fa2728 100644 > > --- a/drivers/net/wireless/mediatek/mt76/mt7615/main.c > > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/main.c > > @@ -37,6 +37,7 @@ static int get_omac_idx(enum nl80211_iftype type, u32 mask) > > > > switch (type) { > > case NL80211_IFTYPE_AP: > > + case NL80211_IFTYPE_MESH_POINT: > > /* ap use hw bssid 0 and ext bssid */ > > if (~mask & BIT(HW_BSSID_0)) > > return HW_BSSID_0; > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > > index 43f70195244c..8b8db526cb16 100644 > > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > > @@ -754,6 +754,7 @@ int mt7615_mcu_set_bss_info(struct mt7615_dev *dev, > > > > switch (vif->type) { > > case NL80211_IFTYPE_AP: > > + case NL80211_IFTYPE_MESH_POINT: > > tx_wlan_idx = mvif->sta.wcid.idx; > > conn_type = CONNECTION_INFRA_AP; > > Just out of curiosity, why not using CONNECTION_MESH_{AP,STA} here? > why not NETWORK_MESH? Actually the CONNECTION_MESH_{AP,STA} are useless and I will send v2 to remove them. > > break; > > @@ -968,7 +969,8 @@ int mt7615_mcu_add_wtbl(struct mt7615_dev *dev, struct ieee80211_vif *vif, > > .rx_wtbl = { > > .tag = cpu_to_le16(WTBL_RX), > > .len = cpu_to_le16(sizeof(struct wtbl_rx)), > > - .rca1 = vif->type != NL80211_IFTYPE_AP, > > + .rca1 = vif->type != (NL80211_IFTYPE_AP || > > + NL80211_IFTYPE_MESH_POINT), > > .rca2 = 1, > > .rv = 1, > > }, > > @@ -1042,6 +1044,7 @@ static void sta_rec_convert_vif_type(enum nl80211_iftype type, u32 *conn_type) > > { > > switch (type) { > > case NL80211_IFTYPE_AP: > > + case NL80211_IFTYPE_MESH_POINT: > > if (conn_type) > > *conn_type = CONNECTION_INFRA_STA; > > break; > > same here. > > Regards, > Lorenzo > > > -- > > 2.18.0 > >