* [PATCH -next 1/6] rtw88: use true,false for bool variable
2019-12-24 14:16 [PATCH -next 0/6] net/wireless: use true,false for bool variable zhengbin
@ 2019-12-24 14:16 ` zhengbin
2020-01-26 15:41 ` Kalle Valo
2019-12-24 14:16 ` [PATCH -next 2/6] cw1200: " zhengbin
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: zhengbin @ 2019-12-24 14:16 UTC (permalink / raw)
To: yhchuang, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/realtek/rtw88/phy.c:1437:1-24: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/realtek/rtw88/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c
index a3e1e95..eea9d88 100644
--- a/drivers/net/wireless/realtek/rtw88/phy.c
+++ b/drivers/net/wireless/realtek/rtw88/phy.c
@@ -1434,7 +1434,7 @@ static void rtw_load_rfk_table(struct rtw_dev *rtwdev)
rtw_load_table(rtwdev, chip->rfk_init_tbl);
- dpk_info->is_dpk_pwr_on = 1;
+ dpk_info->is_dpk_pwr_on = true;
}
void rtw_phy_load_tables(struct rtw_dev *rtwdev)
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH -next 1/6] rtw88: use true,false for bool variable
2019-12-24 14:16 ` [PATCH -next 1/6] rtw88: " zhengbin
@ 2020-01-26 15:41 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2020-01-26 15:41 UTC (permalink / raw)
To: zhengbin; +Cc: yhchuang, davem, linux-wireless, netdev, zhengbin13
zhengbin <zhengbin13@huawei.com> wrote:
> Fixes coccicheck warning:
>
> drivers/net/wireless/realtek/rtw88/phy.c:1437:1-24: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
3 patches applied to wireless-drivers-next.git, thanks.
891984bccf64 rtw88: use true,false for bool variable
ab36bb72d00e cw1200: use true,false for bool variable
b92c017deda8 brcmfmac: use true,false for bool variable
--
https://patchwork.kernel.org/patch/11309351/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH -next 2/6] cw1200: use true,false for bool variable
2019-12-24 14:16 [PATCH -next 0/6] net/wireless: use true,false for bool variable zhengbin
2019-12-24 14:16 ` [PATCH -next 1/6] rtw88: " zhengbin
@ 2019-12-24 14:16 ` zhengbin
2019-12-24 14:16 ` [PATCH -next 3/6] ath9k: " zhengbin
` (3 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-12-24 14:16 UTC (permalink / raw)
To: yhchuang, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/st/cw1200/txrx.c:718:6-16: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/st/cw1200/txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/st/cw1200/txrx.c b/drivers/net/wireless/st/cw1200/txrx.c
index 2dfcdb1..400dd58 100644
--- a/drivers/net/wireless/st/cw1200/txrx.c
+++ b/drivers/net/wireless/st/cw1200/txrx.c
@@ -715,7 +715,7 @@ void cw1200_tx(struct ieee80211_hw *dev,
};
struct ieee80211_sta *sta;
struct wsm_tx *wsm;
- bool tid_update = 0;
+ bool tid_update = false;
u8 flags = 0;
int ret;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH -next 3/6] ath9k: use true,false for bool variable
2019-12-24 14:16 [PATCH -next 0/6] net/wireless: use true,false for bool variable zhengbin
2019-12-24 14:16 ` [PATCH -next 1/6] rtw88: " zhengbin
2019-12-24 14:16 ` [PATCH -next 2/6] cw1200: " zhengbin
@ 2019-12-24 14:16 ` zhengbin
2020-01-26 10:20 ` Kalle Valo
2019-12-24 14:16 ` [PATCH -next 4/6] ath10k: " zhengbin
` (2 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: zhengbin @ 2019-12-24 14:16 UTC (permalink / raw)
To: yhchuang, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/ath/ath9k/ar9003_aic.c:409:2-12: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/ath/ath9k/ar9003_aic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_aic.c b/drivers/net/wireless/ath/ath9k/ar9003_aic.c
index 547cd46..d0f1e8b 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_aic.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_aic.c
@@ -406,7 +406,7 @@ static bool ar9003_aic_cal_post_process(struct ath_hw *ah)
sram.com_att_6db =
ar9003_aic_find_index(1, fixed_com_att_db);
- sram.valid = 1;
+ sram.valid = true;
sram.rot_dir_att_db =
min(max(rot_dir_path_att_db,
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH -next 4/6] ath10k: use true,false for bool variable
2019-12-24 14:16 [PATCH -next 0/6] net/wireless: use true,false for bool variable zhengbin
` (2 preceding siblings ...)
2019-12-24 14:16 ` [PATCH -next 3/6] ath9k: " zhengbin
@ 2019-12-24 14:16 ` zhengbin
2020-01-26 10:30 ` Kalle Valo
2019-12-24 14:16 ` [PATCH -next 5/6] wil6210: " zhengbin
2019-12-24 14:16 ` [PATCH -next 6/6] brcmfmac: " zhengbin
5 siblings, 1 reply; 10+ messages in thread
From: zhengbin @ 2019-12-24 14:16 UTC (permalink / raw)
To: yhchuang, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/ath/ath10k/htt_rx.c:2143:2-31: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 7fb1518..38a5814 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -2140,7 +2140,7 @@ static bool ath10k_htt_rx_pn_check_replay_hl(struct ath10k *ar,
if (last_pn_valid)
pn_invalid = ath10k_htt_rx_pn_cmp48(&new_pn, last_pn);
else
- peer->tids_last_pn_valid[tid] = 1;
+ peer->tids_last_pn_valid[tid] = true;
if (!pn_invalid)
last_pn->pn48 = new_pn.pn48;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH -next 5/6] wil6210: use true,false for bool variable
2019-12-24 14:16 [PATCH -next 0/6] net/wireless: use true,false for bool variable zhengbin
` (3 preceding siblings ...)
2019-12-24 14:16 ` [PATCH -next 4/6] ath10k: " zhengbin
@ 2019-12-24 14:16 ` zhengbin
2019-12-24 14:16 ` [PATCH -next 6/6] brcmfmac: " zhengbin
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-12-24 14:16 UTC (permalink / raw)
To: yhchuang, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/ath/wil6210/main.c:765:1-14: WARNING: Assignment of 0/1 to bool variable
drivers/net/wireless/ath/wil6210/txrx.c:1143:1-19: WARNING: Assignment of 0/1 to bool variable
drivers/net/wireless/ath/wil6210/wmi.c:1516:4-23: WARNING: Assignment of 0/1 to bool variable
drivers/net/wireless/ath/wil6210/wmi.c:1523:4-23: WARNING: Assignment of 0/1 to bool variable
drivers/net/wireless/ath/wil6210/wmi.c:1538:4-30: WARNING: Assignment of 0/1 to bool variable
drivers/net/wireless/ath/wil6210/wmi.c:1545:4-30: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/ath/wil6210/main.c | 2 +-
drivers/net/wireless/ath/wil6210/txrx.c | 2 +-
drivers/net/wireless/ath/wil6210/wmi.c | 8 ++++----
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index 6d39547..3ba5b25 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -762,7 +762,7 @@ int wil_priv_init(struct wil6210_priv *wil)
*/
wil->rx_buff_id_count = WIL_RX_BUFF_ARR_SIZE_DEFAULT;
- wil->amsdu_en = 1;
+ wil->amsdu_en = true;
return 0;
diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c
index 17118d6..bc8c15f 100644
--- a/drivers/net/wireless/ath/wil6210/txrx.c
+++ b/drivers/net/wireless/ath/wil6210/txrx.c
@@ -1140,7 +1140,7 @@ static int wil_tx_desc_map(union wil_tx_desc *desc, dma_addr_t pa,
void wil_tx_data_init(struct wil_ring_tx_data *txdata)
{
spin_lock_bh(&txdata->lock);
- txdata->dot1x_open = 0;
+ txdata->dot1x_open = false;
txdata->enabled = 0;
txdata->idle = 0;
txdata->last_idle = 0;
diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
index dcba0a4..23e1ed6 100644
--- a/drivers/net/wireless/ath/wil6210/wmi.c
+++ b/drivers/net/wireless/ath/wil6210/wmi.c
@@ -1513,14 +1513,14 @@ static void wmi_link_stats_parse(struct wil6210_vif *vif, u64 tsf,
if (vif->fw_stats_ready) {
/* clean old statistics */
vif->fw_stats_tsf = 0;
- vif->fw_stats_ready = 0;
+ vif->fw_stats_ready = false;
}
wil_link_stats_store_basic(vif, payload + hdr_size);
if (!has_next) {
vif->fw_stats_tsf = tsf;
- vif->fw_stats_ready = 1;
+ vif->fw_stats_ready = true;
}
break;
@@ -1535,14 +1535,14 @@ static void wmi_link_stats_parse(struct wil6210_vif *vif, u64 tsf,
if (wil->fw_stats_global.ready) {
/* clean old statistics */
wil->fw_stats_global.tsf = 0;
- wil->fw_stats_global.ready = 0;
+ wil->fw_stats_global.ready = false;
}
wil_link_stats_store_global(vif, payload + hdr_size);
if (!has_next) {
wil->fw_stats_global.tsf = tsf;
- wil->fw_stats_global.ready = 1;
+ wil->fw_stats_global.ready = true;
}
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH -next 6/6] brcmfmac: use true,false for bool variable
2019-12-24 14:16 [PATCH -next 0/6] net/wireless: use true,false for bool variable zhengbin
` (4 preceding siblings ...)
2019-12-24 14:16 ` [PATCH -next 5/6] wil6210: " zhengbin
@ 2019-12-24 14:16 ` zhengbin
5 siblings, 0 replies; 10+ messages in thread
From: zhengbin @ 2019-12-24 14:16 UTC (permalink / raw)
To: yhchuang, kvalo, davem, linux-wireless, netdev; +Cc: zhengbin13
Fixes coccicheck warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c:911:2-24: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
index 2bd892d..5e1a11c 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c
@@ -908,7 +908,7 @@ static u8 brcmf_fws_hdrpush(struct brcmf_fws_info *fws, struct sk_buff *skb)
wlh += wlh[1] + 2;
if (entry->send_tim_signal) {
- entry->send_tim_signal = 0;
+ entry->send_tim_signal = false;
wlh[0] = BRCMF_FWS_TYPE_PENDING_TRAFFIC_BMP;
wlh[1] = BRCMF_FWS_TYPE_PENDING_TRAFFIC_BMP_LEN;
wlh[2] = entry->mac_handle;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread