From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lithops.sigma-star.at (mailout.nod.at [116.203.167.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 179C1324B33; Thu, 12 Mar 2026 19:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.167.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773344034; cv=none; b=j33607n42e689OLFpqcE53xFh+mXzT0DHyFuURweRJDCnHcwW3FtYJuTwAwE7ZtTqn92an8BownNrtmHLhnnlR6hLvKAuI+SoVXShgoz/FNRyMB49rWOhUxMnrt0E5LHZZe0uYfRusDdVxUM+4AJvAJQujoLYUQ8fY7Cwp76ZKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773344034; c=relaxed/simple; bh=VQ4I1//oujMg/wMbvtHZ1fNg62i5rEhIWcPKRohhj4U=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=ddy2a7nze40y2XOq6AzX5P+yK/YAMZEsZCu4is1ZBhMnJKS9vFgMZWqpirXNxVgz6pZsokw/214XhfsoPaQlvyfIqpgQ2GBgjj20XFkl4eJeH0Ugf3RmPz5wDBJf3rAKd+aMd7liJ/M4aSZTOFN9EXdHYYjti5z0jySqd1deAiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at; spf=fail smtp.mailfrom=nod.at; arc=none smtp.client-ip=116.203.167.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nod.at Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nod.at Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 2C14C2C14A6; Thu, 12 Mar 2026 20:33:44 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id mRiNiroB9jYU; Thu, 12 Mar 2026 20:33:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 4E6A02C14A8; Thu, 12 Mar 2026 20:33:43 +0100 (CET) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ZwSNZkVP8UOU; Thu, 12 Mar 2026 20:33:43 +0100 (CET) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id ABF4A2C14A6; Thu, 12 Mar 2026 20:33:42 +0100 (CET) Date: Thu, 12 Mar 2026 20:33:42 +0100 (CET) From: Richard Weinberger To: Philipp Hahn Cc: amd-gfx , apparmor , bpf , ceph-devel , cocci , dm-devel@lists.linux.dev, DRI mailing list , gfs2 , intel-gfx , intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel , linux-block , linux-bluetooth@vger.kernel.org, linux-btrfs , linux-cifs , linux-clk@vger.kernel.org, linux-erofs , linux-ext4 , linux-fsdevel , linux-gpio@vger.kernel.org, linux-hyperv , linux-input@vger.kernel.org, linux-kernel , linux-leds@vger.kernel.org, linux-media , linux-mips , linux-mm , linux-modules@vger.kernel.org, linux-mtd , linux-nfs , linux-omap , linux-phy@lists.infradead.org, linux-pm , linux-rockchip , linux-s390 , linux-scsi , linux-sctp@vger.kernel.org, LSM , linux-sh , linux-sound , linux-stm32 , linux-trace-kernel , linux-usb@vger.kernel.org, linux-wireless , netdev , ntfs3 , samba-technical , sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs , Miquel Raynal , Vignesh Raghavendra Message-ID: <1584421372.26258.1773344022512.JavaMail.zimbra@nod.at> In-Reply-To: <20260310-b4-is_err_or_null-v1-48-bd63b656022d@avm.de> References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> <20260310-b4-is_err_or_null-v1-48-bd63b656022d@avm.de> Subject: Re: [PATCH 48/61] mtd: Prefer IS_ERR_OR_NULL over manual NULL check Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF148 (Linux)/8.8.12_GA_3809) Thread-Topic: Prefer IS_ERR_OR_NULL over manual NULL check Thread-Index: 0l8CyewQmrWlgaG6N3QgQFfukutRbA== ----- Urspr=C3=BCngliche Mail ----- > Von: "Philipp Hahn" > -=09if (gpiomtd->nwp && !IS_ERR(gpiomtd->nwp)) > +=09if (!IS_ERR_OR_NULL(gpiomtd->nwp)) No, please don't. This makes reading the code not easier. Thanks, //richard