From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Kirshenbaum Erez <erezk@wilocity.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] Fix channel index in WMI PCP start
Date: Mon, 3 Jun 2013 18:50:47 +0300 [thread overview]
Message-ID: <1587839.LYoJ4ehe3P@lx-vladimir> (raw)
In-Reply-To: <1370251153-13791-1-git-send-email-erezk@wilocity.com>
On Monday, June 03, 2013 12:19:13 PM Kirshenbaum Erez wrote:
> Signed-off-by: Kirshenbaum Erez <erezk@wilocity.com>
> ---
> drivers/net/wireless/ath/wil6210/wmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
> index 45b04e3..26f760a 100644
> --- a/drivers/net/wireless/ath/wil6210/wmi.c
> +++ b/drivers/net/wireless/ath/wil6210/wmi.c
> @@ -724,7 +724,7 @@ int wmi_pcp_start(struct wil6210_priv *wil, int bi, u8 wmi_nettype, u8 chan)
> .bcon_interval = cpu_to_le16(bi),
> .network_type = wmi_nettype,
> .disable_sec_offload = 1,
> - .channel = chan,
> + .channel = chan-1,
> };
Fix for this already merged, see commit
adc2d12 - wil6210: channel off by 1
To make sure you are aligned, please, prior to sending patch,
rebase on 'master' from
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git
> struct {
> struct wil6210_mbox_hdr_wmi wmi;
> @@ -733,9 +733,9 @@ int wmi_pcp_start(struct wil6210_priv *wil, int bi, u8 wmi_nettype, u8 chan)
>
> if (!wil->secure_pcp)
> cmd.disable_sec = 1;
> -
> + /* This may take some time (FW set/calibrate new freq) */
> rc = wmi_call(wil, WMI_PCP_START_CMDID, &cmd, sizeof(cmd),
> - WMI_PCP_STARTED_EVENTID, &reply, sizeof(reply), 100);
> + WMI_PCP_STARTED_EVENTID, &reply, sizeof(reply), 5000);
> if (rc)
> return rc;
This chunk does not belong to this patch, yes?
Thanks, Vladimir
next prev parent reply other threads:[~2013-06-03 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 9:19 [PATCH] Fix channel index in WMI PCP start Kirshenbaum Erez
2013-06-03 15:50 ` Vladimir Kondratiev [this message]
2013-06-03 23:02 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587839.LYoJ4ehe3P@lx-vladimir \
--to=qca_vkondrat@qca.qualcomm.com \
--cc=erezk@wilocity.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox