From: Christian Lamparter <chunkeey@gmail.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: Rob Herring <robh@kernel.org>,
linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 1/3] dt-bindings: net: add mt76 wireless device binding
Date: Sat, 14 Oct 2017 17:43:51 +0200 [thread overview]
Message-ID: <1589476.LyXlx7DqTg@debian64> (raw)
In-Reply-To: <3828919b-d634-9f03-22ad-1515219c31d4@nbd.name>
On Saturday, October 14, 2017 9:20:46 AM CEST Felix Fietkau wrote:
> On 2017-10-13 21:07, Rob Herring wrote:
> > On Fri, Oct 06, 2017 at 01:02:47PM +0200, Felix Fietkau wrote:
> >> Add documentation describing how device tree can be used to configure
> >> wireless chips supported by the mt76 driver.
> >>
> >> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> >> ---
> >> .../bindings/net/wireless/mediatek,mt76.txt | 24 ++++++++++++++++++++++
> >> 1 file changed, 24 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >> new file mode 100644
> >> index 000000000000..19522ab97d62
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >> @@ -0,0 +1,24 @@
> >> +* MediaTek mt76xx devices
> >> +
> >> +This node provides properties for configuring the MediaTek mt76xx wireless
> >> +device. The node is expected to be specified as a child node of the PCI
> >> +controller to which the wireless chip is connected.
> >> +
> >> +Optional properties:
> >> +
> >> +- mac-address: See ethernet.txt in the parent directory
> >> +- local-mac-address: See ethernet.txt in the parent directory
> >> +- ieee80211-freq-limit: See ieee80211.txt
> >> +- mediatek,mtd-eeprom: Specify a MTD partition + offset containing EEPROM data
> >
> > MTD is a Linuxism. And is an EEPROM the only supported device? I'd
> > suggest naming if after what the data contains.
> PCI cards with this kind of wireless chip usually come with some form of
> EEPROM or use the on-chip OTP ROM.
> This property is for the case where the chip is built into an embedded
> device and the data that would otherwise be on an EEPROM is stored on a
> MTD partition instead.
> The EEPROM data itself contains multiple things: calibration data,
> hardware capabilities, MAC address, etc.
> I couldn't think of a better name for it, do you have any suggestions?
This sort of reminds me of the failed ath9k nvmem patches:
https://patchwork.kernel.org/patch/9622127/
Which uses the nvmem system.
https://github.com/torvalds/linux/blob/master/Documentation/nvmem/nvmem.txt
Rob, would this be acceptable?
Regards,
Christian
next prev parent reply other threads:[~2017-10-14 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 11:02 [PATCH v6 0/3] mt76: add new wireless driver for MediaTek MT76x2 PCIe chips Felix Fietkau
2017-10-06 11:02 ` [PATCH v6 1/3] dt-bindings: net: add mt76 wireless device binding Felix Fietkau
2017-10-13 19:07 ` Rob Herring
2017-10-14 7:20 ` Felix Fietkau
2017-10-14 15:43 ` Christian Lamparter [this message]
2017-10-18 2:02 ` Rob Herring
2017-10-18 6:47 ` Felix Fietkau
2017-10-06 11:02 ` [PATCH v6 2/3] mt76: add common code shared between multiple chipsets Felix Fietkau
2017-10-06 11:02 ` [PATCH v6 3/3] mt76: add driver code for MT76x2e Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589476.LyXlx7DqTg@debian64 \
--to=chunkeey@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox