From: Ryder Lee <ryder.lee@mediatek.com>
To: <sean.wang@mediatek.com>
Cc: <nbd@nbd.name>, <lorenzo.bianconi@redhat.com>,
<Soul.Huang@mediatek.com>, <YN.Chen@mediatek.com>,
<robin.chiu@mediatek.com>, <ch.yeh@mediatek.com>,
<posh.sun@mediatek.com>, <Eric.Liang@mediatek.com>,
<linux-wireless@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [PATCH -next v4 03/13] mt76: mt7921: add MAC support
Date: Fri, 1 Jan 2021 06:58:15 +0800 [thread overview]
Message-ID: <1609455495.20208.8.camel@mtkswgap22> (raw)
In-Reply-To: <3969b56ae9211955428fad2aeba695416362a095.1609347310.git.objelf@gmail.com>
On Thu, 2020-12-31 at 02:06 +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Add Rx packet description parsing, Tx packet description compositon, handle
> packet recycling and provide MAC information mt76 core needs to support
> mac80211.
>
> Co-developed-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Co-developed-by: Soul Huang <Soul.Huang@mediatek.com>
> Signed-off-by: Soul Huang <Soul.Huang@mediatek.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> .../wireless/mediatek/mt76/mt7921/Makefile | 2 +-
> .../net/wireless/mediatek/mt76/mt7921/mac.c | 1364 +++++++++++++++++
Why not put mac.h into this patch?
> 2 files changed, 1365 insertions(+), 1 deletion(-)
> create mode 100644 drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> +int mt7921_tx_prepare_skb(struct mt76_dev *mdev, void *txwi_ptr,
> + enum mt76_txq_id qid, struct mt76_wcid *wcid,
> + struct ieee80211_sta *sta,
> + struct mt76_tx_info *tx_info)
> +{
> + struct mt7921_dev *dev = container_of(mdev, struct mt7921_dev, mt76);
> + struct ieee80211_tx_info *info = IEEE80211_SKB_CB(tx_info->skb);
> + struct ieee80211_key_conf *key = info->control.hw_key;
> + struct mt76_tx_cb *cb = mt76_tx_skb_cb(tx_info->skb);
> + struct mt76_txwi_cache *t;
> + struct mt7921_txp_common *txp;
> + int id;
> + u8 *txwi = (u8 *)txwi_ptr;
Moreover, hardware cannot add LLC-SNAP when skb->data_len is 0, which
causes Tx stuck. We found this case happened on mt7915 (station mode)
quality test with few packets whose skb->len = 14
So,https://github.com/nbd168/wireless/commit/6b6605e4061c94c9909ff82acc0e02bfd3a8d40e
Ryder
next prev parent reply other threads:[~2020-12-31 22:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 18:06 [PATCH -next v4 00/13] introduce mt7921e support sean.wang
2020-12-30 18:06 ` [PATCH -next v4 01/13] mt76: mt7921: add module support sean.wang
2021-01-03 12:00 ` Felix Fietkau
2020-12-30 18:06 ` [PATCH -next v4 02/13] mt76: mt7921: add MCU support sean.wang
2020-12-31 8:55 ` Ryder Lee
2020-12-30 18:06 ` [PATCH -next v4 03/13] mt76: mt7921: add MAC support sean.wang
2020-12-31 8:09 ` Ryder Lee
2020-12-31 22:58 ` Ryder Lee [this message]
2020-12-30 18:06 ` [PATCH -next v4 04/13] mt76: mt7921: add DMA support sean.wang
2020-12-30 18:06 ` [PATCH -next v4 05/13] mt76: mt7921: add EEPROM support sean.wang
2020-12-30 18:06 ` [PATCH -next v4 06/13] mt76: mt7921: add ieee80211_ops sean.wang
2020-12-30 18:06 ` [PATCH -next v4 07/13] mt76: mt7921: introduce mt7921e support sean.wang
2020-12-30 18:06 ` [PATCH -next v4 08/13] mt76: mt7921: add debugfs support sean.wang
2020-12-30 18:06 ` [PATCH -next v4 09/13] mt76: mt7921: introduce schedule scan support sean.wang
2020-12-30 18:06 ` [PATCH -next v4 10/13] mt76: mt7921: introduce 802.11 PS support in sta mode sean.wang
2020-12-30 18:06 ` [PATCH -next v4 11/13] mt76: mt7921: introduce support for hardware beacon filter sean.wang
2020-12-30 18:06 ` [PATCH -next v4 12/13] mt76: mt7921: introduce beacon_loss mcu event sean.wang
2020-12-30 18:06 ` [PATCH -next v4 13/13] mt76: mt7921: introduce PM support sean.wang
[not found] <1609455495.20208.8.camel@mtkswgap22--annotate>
2021-01-01 12:36 ` [PATCH -next v4 03/13] mt76: mt7921: add MAC support sean.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609455495.20208.8.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=Eric.Liang@mediatek.com \
--cc=Soul.Huang@mediatek.com \
--cc=YN.Chen@mediatek.com \
--cc=ch.yeh@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=posh.sun@mediatek.com \
--cc=robin.chiu@mediatek.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).