public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ryder Lee <ryder.lee@mediatek.com>
To: Shayne Chen <shayne.chen@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] mt76: mt7915: force ldpc for bw larger than 20MHz in testmode
Date: Wed, 6 Jan 2021 08:35:56 +0800	[thread overview]
Message-ID: <1609893356.15178.1.camel@mtkswgap22> (raw)
In-Reply-To: <20210105054100.5905-1-shayne.chen@mediatek.com>

On Tue, 2021-01-05 at 13:41 +0800, Shayne Chen wrote:
> LDPC should be set when bw is larger than 20MHz to make
> testmode tx work normally.
> 
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
> index dc1f56fb823d..e8787c336a55 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
> @@ -700,7 +700,7 @@ mt7915_mac_write_txwi_tm(struct mt7915_phy *phy, __le32 *txwi,
>  	if (mode >= MT_PHY_TYPE_HE_SU)
>  		val |= FIELD_PREP(MT_TXD6_HELTF, td->tx_ltf);
>  
> -	if (td->tx_rate_ldpc)
> +	if (td->tx_rate_ldpc || bw > 0)

Prefer explicitly checking bw > IEEE80211_STA_RX_BW_20

>  		val |= MT_TXD6_LDPC;
>  
>  	txwi[6] |= cpu_to_le32(val);

Ryder


      reply	other threads:[~2021-01-06  0:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  5:41 [PATCH] mt76: mt7915: force ldpc for bw larger than 20MHz in testmode Shayne Chen
2021-01-06  0:35 ` Ryder Lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1609893356.15178.1.camel@mtkswgap22 \
    --to=ryder.lee@mediatek.com \
    --cc=evelyn.tsai@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox