* [PATCH v2] rtw88: Simplify bool comparison
@ 2021-01-12 9:50 YANG LI
2021-01-14 17:27 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: YANG LI @ 2021-01-12 9:50 UTC (permalink / raw)
To: tony0620emma
Cc: kvalo, davem, kuba, pkshih, linux-wireless, netdev, linux-kernel,
YANG LI
Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
Comparison of 0/1 to bool variable
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
---
Changes in v2:
make "rtw88:" as subject prefix
drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
index 19fc2d8..948cb79 100644
--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -800,7 +800,7 @@ static ssize_t rtw_debugfs_set_coex_enable(struct file *filp,
}
mutex_lock(&rtwdev->mutex);
- coex->manual_control = enable == 0;
+ coex->manual_control = !enable;
mutex_unlock(&rtwdev->mutex);
return count;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] rtw88: Simplify bool comparison
2021-01-12 9:50 [PATCH v2] rtw88: Simplify bool comparison YANG LI
@ 2021-01-14 17:27 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-01-14 17:27 UTC (permalink / raw)
To: YANG LI
Cc: tony0620emma, davem, kuba, pkshih, linux-wireless, netdev,
linux-kernel, YANG LI
YANG LI <abaci-bugfix@linux.alibaba.com> wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
> Comparison of 0/1 to bool variable
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Patch applied to wireless-drivers-next.git, thanks.
d3a78c7a9daa rtw88: Simplify bool comparison
--
https://patchwork.kernel.org/project/linux-wireless/patch/1610445040-23599-1-git-send-email-abaci-bugfix@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-14 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-12 9:50 [PATCH v2] rtw88: Simplify bool comparison YANG LI
2021-01-14 17:27 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).