From: Govindaraj <gsamin@codeaurora.org>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
Govindaraj <gsamin@codeaurora.org>
Subject: [PATCH] mac80211: fix low throughput due to invalid addba extension
Date: Tue, 16 Mar 2021 21:17:54 +0530 [thread overview]
Message-ID: <1615909674-13412-1-git-send-email-gsamin@codeaurora.org> (raw)
Addba request action frame received with the extension element from
certain 11ac stations, but the cmd id and length not matching to addba
extension and it failing in element parsing. Due to this, addba request
not acknowledged and aggregation not started which is causing low
throughput. Hence validating the cmd id before processing addba extension.
Signed-off-by: Govindaraj <gsamin@codeaurora.org>
---
net/mac80211/agg-rx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/mac80211/agg-rx.c b/net/mac80211/agg-rx.c
index cce28e3..ea473d7 100644
--- a/net/mac80211/agg-rx.c
+++ b/net/mac80211/agg-rx.c
@@ -494,7 +494,8 @@ void ieee80211_process_addba_request(struct ieee80211_local *local,
ies_len = len - offsetof(struct ieee80211_mgmt,
u.action.u.addba_req.variable);
- if (ies_len) {
+ if (ies_len &&
+ mgmt->u.action.u.addba_req.variable[0] == WLAN_EID_ADDBA_EXT) {
ieee802_11_parse_elems(mgmt->u.action.u.addba_req.variable,
ies_len, true, &elems, mgmt->bssid, NULL);
if (elems.parse_error)
--
2.7.4
next reply other threads:[~2021-03-16 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 15:47 Govindaraj [this message]
2021-03-16 15:51 ` [PATCH] mac80211: fix low throughput due to invalid addba extension Johannes Berg
2021-03-16 17:45 ` Govindaraj Saminathan
2021-04-06 18:29 ` Govindaraj Saminathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615909674-13412-1-git-send-email-gsamin@codeaurora.org \
--to=gsamin@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).