From: Ryder Lee <ryder.lee@mediatek.com>
To: Ben Greear <greearb@candelatech.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Shayne Chen <shayne.chen@mediatek.com>,
<linux-wireless@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 2/2] mt76: mt7915: add .set_bitrate_mask() callback
Date: Tue, 27 Apr 2021 03:11:27 +0800 [thread overview]
Message-ID: <1619464287.15845.2.camel@mtkswgap22> (raw)
In-Reply-To: <7776c0d1-0578-5922-1003-f8498cc0357a@candelatech.com>
On Mon, 2021-04-26 at 11:41 -0700, Ben Greear wrote:
> On 4/26/21 9:29 AM, Ryder Lee wrote:
> > Add runtime configuration for bitrate mask. Note that GI cannot be setup.
> >
> > Example:
> > iw dev wlan0 set bitrates vht-mcs-5 1:9 he-mcs-5 2:7
> > iw dev wlan0 set bitrates legacy-5 6 he-mcs-5 2:0-11
>
> Is this only for data frames? In other words, is it OK to
> set exactly one HE/VHT MCS rate and let mgt, bcast, mcast, still
> work OK at legacy rates?
>
> Thanks,
> Ben
>
Yes. And this's more like a 'limit', and it actually re-initializes
firmware rate control for each peer to add a boundry on top of rate
table. When you specify something like 'iw dev wlan0 set bitrates
vht-mcs-5 1:9', which means nss=1 mcs0-9 actually. If you would like
stick to a fixed rate then there's a knob in mt7915 debugfs.
As for other the mgmt, mcast, bcast should sill remain in low rate.
prev parent reply other threads:[~2021-04-26 19:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 16:29 [PATCH 1/2] mt76: mt7915: cleanup mt7915_mcu_sta_rate_ctrl_tlv() Ryder Lee
2021-04-26 16:29 ` [PATCH 2/2] mt76: mt7915: add .set_bitrate_mask() callback Ryder Lee
2021-04-26 18:41 ` Ben Greear
2021-04-26 19:11 ` Ryder Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619464287.15845.2.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=greearb@candelatech.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).