From: Kalle Valo <kvalo@kernel.org>
To: Youghandhar Chintala <youghand@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, pillair@codeaurora.org,
dianders@chromium.org, kuabhs@chromium.org,
briannorris@chromium.org, mpubbise@codeaurora.org,
Youghandhar Chintala <youghand@codeaurora.org>
Subject: Re: [PATCH v6 2/2] ath10k: Trigger sta disconnect on hardware restart
Date: Mon, 21 Mar 2022 10:46:44 +0000 (UTC) [thread overview]
Message-ID: <164785960237.19083.15185904446289698730.kvalo@kernel.org> (raw)
In-Reply-To: <20220315082944.12406-3-youghand@codeaurora.org>
Youghandhar Chintala <youghand@codeaurora.org> wrote:
> Currently after the hardware restart triggered from the driver,
> the station interface connection remains intact, since a disconnect
> trigger is not sent to userspace. This can lead to a problem in
> targets where the wifi mac sequence is added by the firmware.
>
> After the target restart, its wifi mac sequence number gets
> reset to zero. Hence AP to which our device is connected will receive
> frames with a wifi mac sequence number jump to the past, thereby
> resulting in the AP dropping all these frames, until the frame
> arrives with a wifi mac sequence number which AP was expecting.
>
> To avoid such frame drops, its better to trigger a station disconnect
> upon target hardware restart which can be done with API
> ieee80211_reconfig_disconnect exposed to mac80211.
>
> The other targets are not affected by this change, since the hardware
> params flag is not set.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
> Tested-on: QCA6174 hw3.2 PCI WLAN.RM.4.4.1-00110-QCARMSWP-1
> Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00048
>
> Signed-off-by: Youghandhar Chintala <youghand@codeaurora.org>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
2c3fc50591ff ath10k: Trigger sta disconnect on hardware restart
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220315082944.12406-3-youghand@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-03-21 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 8:29 [PATCH v6 0/2] mac80211: Trigger disconnect for STA during target hardware restart Youghandhar Chintala
2022-03-15 8:29 ` [PATCH v6 1/2] mac80211: Add support to trigger sta disconnect on " Youghandhar Chintala
2022-03-15 8:32 ` Johannes Berg
2022-03-15 8:29 ` [PATCH v6 2/2] ath10k: Trigger " Youghandhar Chintala
2022-03-21 10:46 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164785960237.19083.15185904446289698730.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=kuabhs@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mpubbise@codeaurora.org \
--cc=pillair@codeaurora.org \
--cc=youghand@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox