Linux wireless drivers development
 help / color / mirror / Atom feed
From: Helmut Schaa <helmut.schaa@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: Re: [PATCH] mac80211: Fix endian bug in radiotap header generation
Date: Fri, 18 Nov 2011 21:56:20 +0100	[thread overview]
Message-ID: <1654464.RY7RQ6RAa1@helmutmobil.site> (raw)
In-Reply-To: <1321632520.10266.66.camel@jlt3.sipsolutions.net>

Am Freitag, 18. November 2011, 17:08:40 schrieb Johannes Berg:
> Heh I would've fixed it by just using put_unaligned(txflags, pos) here,
> but either is fine with me :-)

Hmm, right, but using this approach we even save some cpu_to_le16 calls on
BE archs and maybe some day I'll learn to always build with "make C=1" to
catch endian bugs before sending a patch :)

Thanks,
Helmut

  reply	other threads:[~2011-11-18 19:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-11 16:08 [PATCH 1/2] mac80211: Build TX radiotap header dynamically Helmut Schaa
2011-10-11 16:08 ` [PATCH 2/2] mac80211: Populate radiotap header with MCS info for TX frames Helmut Schaa
2011-10-11 16:25 ` [PATCH 1/2] mac80211: Build TX radiotap header dynamically Johannes Berg
2011-10-11 17:19   ` Helmut Schaa
2011-10-11 17:38     ` Johannes Berg
2011-11-18 14:31 ` Johannes Berg
2011-11-18 16:02   ` [PATCH] mac80211: Fix endian bug in radiotap header generation Helmut Schaa
2011-11-18 16:08     ` Johannes Berg
2011-11-18 20:56       ` Helmut Schaa [this message]
2011-11-18 20:16         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1654464.RY7RQ6RAa1@helmutmobil.site \
    --to=helmut.schaa@googlemail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox