From: Kalle Valo <kvalo@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, Chad Monroe <chad.monroe@smartrg.com>
Subject: Re: [PATCH 6.1 1/2] wifi: mt76: fix receiving LLC packets on mt7615/mt7915
Date: Tue, 11 Oct 2022 08:42:02 +0000 (UTC) [thread overview]
Message-ID: <166547771808.14345.12170744535376568553.kvalo@kernel.org> (raw)
In-Reply-To: <20221005130824.23371-1-nbd@nbd.name>
Felix Fietkau <nbd@nbd.name> wrote:
> When 802.3 decap offload is enabled, the hardware indicates header translation
> failure, whenever either the LLC-SNAP header was not found, or a VLAN header
> with an unregcognized tag is present.
> In that case, the hardware inserts a 2-byte length fields after the MAC
> addresses. For VLAN packets, this tag needs to be removed. However,
> for 802.3 LLC packets, the length bytes should be preserved, since there
> is no separate ethertype field in the data.
> This fixes an issue where the length field was omitted for LLC frames, causing
> them to be malformed after hardware decap.
>
> Fixes: 1eeff0b4c1a6 ("mt76: mt7915: fix decap offload corner case with 4-addr VLAN frames")
> Reported-by: Chad Monroe <chad.monroe@smartrg.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
2 patches applied to wireless.git, thanks.
47c44088ac08 wifi: mt76: fix receiving LLC packets on mt7615/mt7915
443dc85ad13e wifi: mt76: fix rx checksum offload on mt7615/mt7915/mt7921
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221005130824.23371-1-nbd@nbd.name/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-10-11 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 13:08 [PATCH 6.1 1/2] wifi: mt76: fix receiving LLC packets on mt7615/mt7915 Felix Fietkau
2022-10-05 13:08 ` [PATCH 6.1 2/2] wifi: mt76: fix rx checksum offload on mt7615/mt7915/mt7921 Felix Fietkau
2022-10-11 8:42 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166547771808.14345.12170744535376568553.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=chad.monroe@smartrg.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox