From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFBB7C38159 for ; Wed, 18 Jan 2023 07:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbjARHJZ (ORCPT ); Wed, 18 Jan 2023 02:09:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbjARHIz (ORCPT ); Wed, 18 Jan 2023 02:08:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6DDF6C571; Tue, 17 Jan 2023 22:35:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 65BD2B81B43; Wed, 18 Jan 2023 06:35:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A980BC433EF; Wed, 18 Jan 2023 06:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674023722; bh=UsZhg3e/FoLkTU5R3hvEWS8a+d3s1oq7ddrZA6/R5ZE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=rkbSW35Tf5XzQltEqJK1XK2bgCeGOIyt0k25tAaDauGymr2QAEfDKzjLEafnEjg+m 6E6ixXFJP/Y9sgiaTtGf2DqLLGJvJFj9/1i0m0cjW/wco172djAyy4Ov+NqBuKxiWO 3y3GLZwo09QopS8eFVfnls35rdFuHELzhIEiDBmYLZhMHzZkFXxFyWqWS9RavSE1O/ vseCn2qrZgium/eGEvupTLm9c3qnLKVKNl9SKV28uDZzYhQWBQTyxYlEsDFRWZE2ZF bCoCim3jlVYAqNW1Z+2eZil5DZqMu0Zg5Iaf/v2cX0+NbguVqGFS15L4/ze4n2WPgN czNXfcZZ5tRKg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: ath11k: Fix memory leak in ath11k_peer_rx_frag_setup From: Kalle Valo In-Reply-To: <20230102081142.3937570-1-linmq006@gmail.com> References: <20230102081142.3937570-1-linmq006@gmail.com> To: Miaoqian Lin Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Manikanta Pubbisetty , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linmq006@gmail.com User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167402371642.24104.14787775190477327666.kvalo@kernel.org> Date: Wed, 18 Jan 2023 06:35:19 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Miaoqian Lin wrote: > crypto_alloc_shash() allocates resources, which should be released by > crypto_free_shash(). When ath11k_peer_find() fails, there has memory > leak. Add missing crypto_free_shash() to fix this. > > Fixes: 243874c64c81 ("ath11k: handle RX fragments") > Signed-off-by: Miaoqian Lin > Reviewed-by: Leon Romanovsky > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ed3f83b3459a wifi: ath11k: Fix memory leak in ath11k_peer_rx_frag_setup -- https://patchwork.kernel.org/project/linux-wireless/patch/20230102081142.3937570-1-linmq006@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches