From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C3EC04A94 for ; Wed, 2 Aug 2023 18:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234142AbjHBSX3 (ORCPT ); Wed, 2 Aug 2023 14:23:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233181AbjHBSX2 (ORCPT ); Wed, 2 Aug 2023 14:23:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AA80BA; Wed, 2 Aug 2023 11:23:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D265661AA0; Wed, 2 Aug 2023 18:23:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5489EC433C8; Wed, 2 Aug 2023 18:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691000606; bh=v7hq7FeZtaf/kJ+hTvesuISlZhktfFix0bKvyjiDK1A=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=JJiKTcQCxhGuYSfSrBd3pA0FHRLtvBii0EnE1kl8uhcV+h8Q0o/m7QviZYZZOurUY cQXuR6auCpB/vi6ldNAa6AkgfLfdZ3WRregvGvB1A9b3NWGExIReVHxTQhx+0c54eq O4lDYkXMlg2g/Sr7/EAXJepW2RnhyANAR0PSD3OaNKN6p0UFkZ5onmF6pb9z6696BL ZrnBn1Rem5uBkHq32412F048hPur3VOhd0pn1b4NZsX3aH5TJxorxB6gcOh0Xpe+Zm VvyEacYzUOWeOCkXNmC32rNEW5sMJBzep9Kcv8aGQjMDQ5Cm2AARa3DlEY9ykpU+cm 7M/C4wFrFlLCQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath6kl: Fix debugfs_create_dir error checking From: Kalle Valo In-Reply-To: <20230731024542.27248-1-rauji.raut@gmail.com> References: <20230731024542.27248-1-rauji.raut@gmail.com> To: Atul Raut Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169100060344.669727.8392314523199758602.kvalo@kernel.org> Date: Wed, 2 Aug 2023 18:23:25 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Atul Raut wrote: > The debugfs_create_dir function returns ERR_PTR > in case of error and the correct way to check an > error is 'IS_ERR' inline function. > This patch will replace the null-comparison with IS_ERR > > This issue was found with the help of Coccinelle. > ./drivers/net/wireless/ath/ath6kl/debug.c:1796:6-21: Wrong debugfs call error processing on line 1796 > > Signed-off-by: Atul Raut This has been already fixed: https://git.kernel.org/kvalo/ath/c/1301783c8def Patch set to Rejected. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230731024542.27248-1-rauji.raut@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches