Re: [PATCH] ath9k: Differentiate between max combined and per chain power

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Wednesday, 20 March 2019 14:49:57 CET Tom Psyborg wrote:
> On 20/03/2019, Sven Eckelmann <sven@narfation.org> wrote:
> 
> > This also means that a device with multiple tx chains is even limited
> > further:
> >
> > * 1 chain:  31 dBm per chain
> > * 2 chains: 28 dBm per chain
> > * 3 chains: 26 dBm per chain
> >
> 
> This is flawed theory and should be reverted instead of making further
> complications. Simplest way would be to remove
> POWER_CORRECTION_FOR_TWO_CHAIN and POWER_CORRECTION_FOR_THREE_CHAIN;
> from driver

You can of course propose a patch for that. But I will not participate in the 
discussion how EIRP should be measured (per antenna/per system, on max point/
via integral over all positions, ...).

And you should also discuss it with QCA to find out whether they will also 
remove the power correction from their closed source firmware. At least it 
would also affect ath10k... maybe even their other drivers with closed source 
components.

And your change would also not completely supersede my change. You forget that 
the antennagain reduction is also done by scaled ath9k_hw_get_scaled_power.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]