From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23875745E7 for ; Tue, 12 Dec 2023 15:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rlewShFq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 947BFC433C8; Tue, 12 Dec 2023 15:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702395237; bh=SmtuEPtz2gzeGWshtG4uyVitXKymgOX+I4Y5KbfxugY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=rlewShFqcuUl6vDGpo3zWkQ7SBnDE5lCbYdC7i2VNcygpJjq0aHvF6ZhnKu54uz3m OjD0cq/NZ2Ogknuk26z7NB559boqbVAwrNRRz1LYZIXaLDOv5GOoGwMVepFM65Q2Gf olf39Qh/K/raIGyWG5FfBzhorsycp0xTgWw2x6EO7wn7ziCF0G/I6/sD+J0hpDw/pr SUzySXvY/eBRBWqxUq+PLMtoUP8jz6KBiyx3q7J1pm/6zZtBqdds3f2zVb05DasPXX L+BiD+TnVM4yaBzxKyXShsXoVE67q4Kni5mkSONf4nwfEIzWg+kxffa7Gcvsn9fSf2 Ziqz3wKZX7Omw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] [v2] wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap() From: Kalle Valo In-Reply-To: <20231204171130.141394-1-dmantipov@yandex.ru> References: <20231204171130.141394-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170239523486.306086.11081054761735542992.kvalo@kernel.org> Date: Tue, 12 Dec 2023 15:33:56 +0000 (UTC) Dmitry Antipov wrote: > Since 'ieee80211_beacon_get()' can return NULL, 'wfx_set_mfp_ap()' > should check the return value before examining skb data. So convert > the latter to return an appropriate error code and propagate it to > return from 'wfx_start_ap()' as well. Compile tested only. > > Signed-off-by: Dmitry Antipov > Tested-by: Jérôme Pouiller > Acked-by: Jérôme Pouiller Patch applied to wireless-next.git, thanks. fe0a7776d4d1 wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231204171130.141394-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches