From: Kalle Valo <kvalo@kernel.org>
To: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Cc: Jonas Gorski <jonas.gorski@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Artem Chernyshev <artem.chernyshev@red-soft.ru>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Arend van Spriel <aspriel@gmail.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [v2] wifi: brcmsmac: phy: Remove unreachable code
Date: Thu, 18 Jan 2024 13:05:01 +0000 (UTC) [thread overview]
Message-ID: <170558309941.2924528.648376255659040623.kvalo@kernel.org> (raw)
In-Reply-To: <20230814093621.289754-1-artem.chernyshev@red-soft.ru>
Artem Chernyshev <artem.chernyshev@red-soft.ru> wrote:
> wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy() can not
> return false, so it's impossible to get true value in this
> if-statement. Also change those functions return types to void
> since no one using it.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
> Reviewed-by: Jonas Gorski <jonas.gorski@gmail.com>
Patch applied to wireless-next.git, thanks.
47f0e32ffe4e wifi: brcmsmac: phy: Remove unreachable code
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230814093621.289754-1-artem.chernyshev@red-soft.ru/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-01-18 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 21:23 [PATCH] brcm80211: brcmsmac: phy_cmn: Remove unreachable code Artem Chernyshev
2023-08-14 7:19 ` Jonas Gorski
2023-08-14 7:24 ` Artem Chernyshev
2023-08-14 9:36 ` [PATCH v2] brcm80211: brcmsmac: phy: " Artem Chernyshev
2023-08-25 8:34 ` Jonas Gorski
2024-01-18 13:05 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170558309941.2924528.648376255659040623.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=artem.chernyshev@red-soft.ru \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox